<html> <head> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> Hi Abhishek, The code appears to be correct, provided that the previously refactored code (which I did not review) works correctly, and it does not break the non-REST code. Could you please 1. provide a signed audit log event for one revocation request from the cli, where it shows an actual request id and verify that it is indeed the correct request id? 2.perform one single revocation from the non-REST agent interface and then verify the same revocation log event type for log request id? thanks, Christina <div class="moz-cite-prefix">On 05/05/2014 03:48 AM, Abhishek Koneru wrote: </div> <blockquote cite="mid:1399286894.3985.8.camel@akoneru.redhat.com" type="cite"> <pre wrap="">Sorry for the spam! Please ignore the previous email. --Abhishek On Mon, 2014-05-05 at 06:44 -0400, Abhishek Koneru wrote: </pre> <blockquote type="cite"> <pre wrap="">Please review the patch which refactors the CertRevokeRequest class and removes the CertUnrevokeRequest class in Dogtag 10. Description of the patch: There seems to be no use of the requestID parameter in both revoke and unrevoke request. Removed requestID attribute in CertRevokeRequest remove the class CertUnrevokeRequest. Also made changes in RevocationProcesor to use the requestID of the request created in it. The setRequestID() is being called in the DoRevoke and DoUnRevoke servlets. Removed the call and a function auditRequesterId in both the classes. The auditRequestorId method tries to get a "requestID" stored as a INPUT field in the reasonToRequest page. The ReasonToRevoke class which generates this page does not set the value. * This patch is required for patch 92. The unrevoke_request method in CertClient on the python side will not work without this patch. --Abhishek _______________________________________________ Pki-devel mailing list <a class="moz-txt-link-abbreviated" href="mailto:Pki-devel@redhat.com">Pki-devel@redhat.com</a> <a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/pki-devel">https://www.redhat.com/mailman/listinfo/pki-devel</a> </pre> </blockquote> <pre wrap=""> </pre> <fieldset class="mimeAttachmentHeader"></fieldset> <pre wrap="">_______________________________________________ Pki-devel mailing list <a class="moz-txt-link-abbreviated" href="mailto:Pki-devel@redhat.com">Pki-devel@redhat.com</a> <a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/pki-devel">https://www.redhat.com/mailman/listinfo/pki-devel</a></pre> </blockquote> </body> </html>