<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
other than the null pointer, I also suspect that this patch might
not be cross-platform (or cross-tomcat-version, rather). I do
recall that at some point in the past when attr doesn't exist in
endpoint.getAttribute(attr), it throws an exception instead of
returning a null. You might want to consider putting the changes
from try/catch block to (the to-be-added) null checks in a separate
patch.<br>
<br>
Christina<br>
<br>
<div class="moz-cite-prefix">On 04/20/2015 02:21 PM, Ade Lee wrote:<br>
</div>
<blockquote cite="mid:1429564870.2839.9.camel@aleeredhat.laptop"
type="cite">
<pre wrap="">One small change .. See attached patch instead.
Ade
On Mon, 2015-04-20 at 17:06 -0400, Ade Lee wrote:
</pre>
<blockquote type="cite">
<pre wrap="">This patch adds nuxwodg support to tomcatjss. In addition, it cleans up
some of the init code for tomcatjss, especially with regards to
initializing the password store and logging into tokens.
This patch is still untested - so its just a preview. But I expect the
final patch to look very similar to this one.
Ade
_______________________________________________
Pki-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Pki-devel@redhat.com">Pki-devel@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/pki-devel">https://www.redhat.com/mailman/listinfo/pki-devel</a>
</pre>
</blockquote>
<pre wrap="">
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Pki-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Pki-devel@redhat.com">Pki-devel@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/pki-devel">https://www.redhat.com/mailman/listinfo/pki-devel</a></pre>
</blockquote>
<br>
</body>
</html>