<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=utf-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-forward-container"><br>
<br>
-------- Forwarded Message --------
<table class="moz-email-headers-table" border="0" cellpadding="0"
cellspacing="0">
<tbody>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">Subject:
</th>
<td>Re: [Pki-devel] patches to fix pkispawn issues</td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">Date: </th>
<td>Wed, 29 Apr 2015 15:26:48 -0600</td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">From: </th>
<td>Matthew Harmsen <a class="moz-txt-link-rfc2396E" href="mailto:mharmsen@redhat.com"><mharmsen@redhat.com></a></td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">To: </th>
<td><a class="moz-txt-link-abbreviated" href="mailto:alee@redhat.com">alee@redhat.com</a></td>
</tr>
</tbody>
</table>
<br>
<br>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<div class="moz-cite-prefix">On 04/29/15 13:34, Ade Lee wrote:<br>
</div>
<blockquote cite="mid:1430336086.4578.3.camel@aleeredhat.laptop"
type="cite">
<pre wrap="">Attached revised patch to address issue found.
If the port is not found, we will now prompt.
Ade
On Wed, 2015-04-29 at 13:10 -0600, Matthew Harmsen wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On 04/29/15 11:58, Ade Lee wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Please review attached patches:
commit d33caa4c1302ecc1d2fc3c42d85544a2653dd09a
Author: Ade Lee <a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:alee@redhat.com"><alee@redhat.com></a>
Date: Wed Apr 29 12:46:19 2015 -0400
Fix interactive install to not reprompt for ports
Ports are already set when deploying into an existing instance.
Having a user re-enter these is repetitious and error prone.
commit f0a5c5c79e9918c362f73103891e11f2f7dc6bbb
Author: Ade Lee <a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:alee@redhat.com"><alee@redhat.com></a>
Date: Wed Apr 29 11:11:41 2015 -0400
Trac Ticket 1196 - serverCertNick.conf is replaced incorrectly
When second subsystem is installed, serverCertNick.conf and other
top level
tomcat config files should not be replaced.
commit b0317d50fd302086dd324f69d11647f655ddd9bd
Author: Ade Lee <a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:alee@redhat.com"><alee@redhat.com></a>
Date: Wed Apr 29 10:57:09 2015 -0400
Code cleanup - simplify pkispawn code
All subsystems are now tomcat instances. Conditionals based on
whether the subsystem is a tomcat instance or not are no longer
required.
_______________________________________________
Pki-devel mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:Pki-devel@redhat.com">Pki-devel@redhat.com</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/pki-devel">https://www.redhat.com/mailman/listinfo/pki-devel</a>
</pre>
</blockquote>
<pre wrap="">NACK
Unfortunately, as discussed on IRC, if non-interactive mode was
utilized to originally setup your instance, and then further instances
utilized interactive mode within that instance, reading directories
under /etc/sysconfig/pki/tomcat/pki-tomcat may find a 'deployment.cfg'
that only contains the file that was utilized to non-interactively
install the original instance. This would return data to make
existing_data true, but unfortunately would not contain the fields
required.
</pre>
</blockquote>
</blockquote>
ACK<br>
<br>
CAVEAT: Will change line in set_port() from:<br>
<ul>
<li>if existing_data[tag]:</li>
</ul>
to:<br>
<ul>
<li>if tag in existing_data:</li>
</ul>
<p><br>
</p>
<br>
</div>
<br>
</body>
</html>