<html> <head> <meta content="text/html; charset=windows-1252" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> Overall, it looks good. Just some minor suggestions, mostly for clarification purposes. * SecureChannel.java : clearAppletKeySlotData - would appreciate comments describing the content and format expected in the input "data" - maybe a positive debug message after the successful cleanup (as negative result is non-fatal regardless) * PKCS11Obj.java : getKeyIndexList - please add high level comment to tell what this does - how about go with the convention and assign a String method for debug messages? - I couldn't figure out why the code needs to traverse the cert objects while it has no interest in them; I don't think it hurts though; I'm okay with it if you decide to leave it in. - One question: if TPSBuffer data ends up not having anything add to it, will this reference blow up? data.toHexString() Conditional ACK. thanks, Christina <div class="moz-cite-prefix">On 12/16/2016 04:28 PM, John Magne wrote: </div> <blockquote cite="mid:2095269352.8138640.1481934532217.JavaMail.zimbra@redhat.com" type="cite"> <pre wrap="">Author: Jack Magne <a class="moz-txt-link-rfc2396E" href="mailto:jmagne@dhcp-16-206.sjc.redhat.com"><jmagne@dhcp-16-206.sjc.redhat.com></a> Date: Fri Dec 16 16:25:48 2016 -0800 Ticket #2569: Token memory not wiped after key deletion This is the dogtag upstream side of the TPS portion of this ticket. This fix also involves an applet fix, handled in another bug. </pre> <fieldset class="mimeAttachmentHeader"></fieldset> <pre wrap="">_______________________________________________ Pki-devel mailing list <a class="moz-txt-link-abbreviated" href="mailto:Pki-devel@redhat.com">Pki-devel@redhat.com</a> <a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/pki-devel">https://www.redhat.com/mailman/listinfo/pki-devel</a></pre> </blockquote> </body> </html>