<div dir="ltr">+1 on that<div><br></div><div>We are doing both currently for Pulp Smash. I set the label and approve the PR, maybe we can move completely to review as well.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Oct 3, 2016 at 6:43 PM, Sean Myers <span dir="ltr"><<a href="mailto:sean.myers@redhat.com" target="_blank">sean.myers@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Github's new review feature is supported by another new github feature,<br>
protected branches. If wanted to, we could combine the two ideas, and<br>
only push to protected branches if there is at least one approved review<br>
and no review with required changes outstanding.<br>
<br>
I think this could be used instead of the "LGTM" label, and can also help<br>
with the notion of "drive-by" reviews, since the UI gives you a clear<br>
distinction between comments that require changes to be made and comments<br>
that do not require changes to be made.<br>
<br>
For reference:<br>
<a href="https://help.github.com/articles/about-pull-request-reviews/" rel="noreferrer" target="_blank">https://help.github.com/<wbr>articles/about-pull-request-<wbr>reviews/</a><br>
<br>
Since we've already got support for protected branches, I propose we<br>
enable required reviews, and stop using the LGTM label.<br>
<br>
<br>______________________________<wbr>_________________<br>
Pulp-dev mailing list<br>
<a href="mailto:Pulp-dev@redhat.com">Pulp-dev@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/<wbr>mailman/listinfo/pulp-dev</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Elyézer Rezende<div>Senior Quality Engineer<br><div>irc: elyezer</div></div></div></div>
</div>