<div dir="ltr"><div><div><div>I left many comments. Mostly language and clarification requests.<br><br></div>Since there are so many comments the pull request is a bit unreadable. FYI, you can see a rendered version of the current state here:  <a href="https://github.com/asmacdo/pups/blob/google-docstrings/pup-0002.md">https://github.com/asmacdo/pups/blob/google-docstrings/pup-0002.md</a><br><br></div>Thanks @asmacdo for leading this.<br><br></div>-Brian<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Apr 10, 2017 at 2:14 PM, Austin Macdonald <span dir="ltr"><<a href="mailto:austin@redhat.com" target="_blank">austin@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">PUP 2 [0] is still getting feedback and changing, so we are extending the vote to April 12 at 9pm UTC [1]. Voting procedure is described in PUP 1. [2]<div><br></div><div>Comments, nitpicks, and votes are welcome from anyone who is interested!<br><div><div><div><br></div><div><span style="font-size:12.8px">[0] - </span><a href="https://github.com/pulp/pups/pull/2" style="font-size:12.8px" target="_blank">https://github.com/pulp/pups<wbr>/pull/2</a><br></div><div>[1] - <a href="http://bit.ly/2oXOREo" target="_blank">http://bit.ly/2oXOREo</a></div></div></div></div><div>[2] - <a href="https://github.com/pulp/pups/blob/master/pup-0001.md#voting" target="_blank">https://github.com/pulp/pups<wbr>/blob/master/pup-0001.md#votin<wbr>g</a></div></div>
<br>______________________________<wbr>_________________<br>
Pulp-dev mailing list<br>
<a href="mailto:Pulp-dev@redhat.com">Pulp-dev@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/<wbr>mailman/listinfo/pulp-dev</a><br>
<br></blockquote></div><br></div>