<div dir="ltr">I think we want all setup.py files to remain with a single subdirectory of the git repo's root. Each such directory can have a human-readable name that should likely correspond to the python package name. Each such directory must contain a "pulpcore" directory containing that package's source, side-by-side with the setup.py file.<div><br></div><div>If we had:</div><div><br></div><div>pulpcore/setup.py</div><div>pulpcore/app/</div><div><br></div><div>... then the root of the python namespace would be "app", which is not what we want. It would be "from app import ..."</div><div><br></div><div>So given that understanding, I think we would just rename the "platform" directory to "core" to match our existing layout. Or we could name it "pulpcore" to exactly match the python package name, but then we'd presumably rename all the other top level package directories to begin with the word "pulp", which may not be desirable.<br></div><div><br></div><div>Does that make sense? I don't think we should move anything up a level, but just rename.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jun 19, 2017 at 2:54 PM, Austin Macdonald <span dir="ltr"><<a href="mailto:austin@redhat.com" target="_blank">austin@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">We recently made the decision to namespace Pulp as "pulpcore" [0], but this has made our app location a little awkward: `pulp/platform/pulpcore/app`<div><br></div><div>To kick off the conversation, I think the best place to start is a map of all of the setup.py files:<br></div><div><br></div><div>bindings/setup.py</div><div>client_admin/setup.py</div><div>client_consumer/setup.py </div><div>client_lib/setup.py</div><div>common/setup.py</div><div>devel/setup.py</div><div>oid_validation/setup.py</div><div>platform/setup.py</div><div>plugins/setup.py</div><div>repoauth/setup.py</div><div>server/setup.py</div><div>streamer/setup.py</div><div><br></div><div><br></div><div><div>To me, it makes sense that pulpcore should move up a level, so the app would live in `pulp/pulpcore/app` and the setup py would live in `pulp/pulpcore/setup.py`</div></div><div><br></div><div><br></div><div><div><div>[0]: <a href="https://www.redhat.com/archives/pulp-dev/2017-May/msg00030.html" target="_blank">https://www.redhat.com/<wbr>archives/pulp-dev/2017-May/<wbr>msg00030.html</a></div></div></div></div>
<br>______________________________<wbr>_________________<br>
Pulp-dev mailing list<br>
<a href="mailto:Pulp-dev@redhat.com">Pulp-dev@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/<wbr>mailman/listinfo/pulp-dev</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><p style="color:rgb(0,0,0);font-family:overpass-mono,monospace;font-size:10px;margin:0px!important;padding:0px!important"><span style="margin:0px!important;padding:0px!important">Michael</span> <span style="margin:0px!important;padding:0px!important">Hrivnak</span></p><p style="color:rgb(0,0,0);font-family:overpass-mono,monospace;font-size:10px;margin:0px!important;padding:0px!important"></p><span style="color:rgb(0,0,0);font-family:overpass-mono,monospace;font-size:10px;margin:0px!important;padding:0px!important"><span style="margin:0px!important;padding:0px!important">Principal Software Engineer</span><span style="margin:0px!important;padding:0px!important">, <span style="margin:0px!important;padding:0px!important">RHCE</span></span> </span><span style="color:rgb(0,0,0);font-family:overpass-mono,monospace;font-size:10px"></span><br style="color:rgb(0,0,0);font-family:overpass-mono,monospace;font-size:10px;margin:0px!important;padding:0px!important"><p style="color:rgb(0,0,0);font-family:overpass-mono,monospace;font-size:10px;margin:0px!important;padding:0px!important">Red Hat</p></div></div>
</div>