<div dir="ltr">I'm not totally sure on this, but I think since the pulp_file plugin is defining the File content type and additional fields it has to also define the filterset that goes with it.<br><br>Can someone else with more DRF experience confirm that plugin writers must define a filterset for pulp to work? Or could a plugin writer in some cases use a generic FilterSet that would be provided by core?<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Sep 18, 2017 at 8:58 PM, Tatiana Tereshchenko <span dir="ltr"><<a href="mailto:ttereshc@redhat.com" target="_blank">ttereshc@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>There are FilterSets [0][1] defined for master models, so they can be used as-is or extended by plugin for detail models. Currently they don't seem to be available via plugin API and plugin defines its own FilterSet [2]. Is it intentional?<br>I suggest to add them to pulpcore.plugin.<br></div><div><br></div><div>Thanks,<br></div><div>Tanya<br><br>[0] <a href="https://github.com/pulp/pulp/blob/ba6792d9740ab7e104df8147806e80fe22ae483a/platform/pulpcore/app/viewsets/repository.py#L68-L115" target="_blank">https://github.com/pulp/pulp/<wbr>blob/<wbr>ba6792d9740ab7e104df8147806e80<wbr>fe22ae483a/platform/pulpcore/<wbr>app/viewsets/repository.py#<wbr>L68-L115</a><br>[1] <a href="https://github.com/pulp/pulp/blob/ba6792d9740ab7e104df8147806e80fe22ae483a/platform/pulpcore/app/viewsets/content.py#L12" target="_blank">https://github.com/pulp/pulp/<wbr>blob/<wbr>ba6792d9740ab7e104df8147806e80<wbr>fe22ae483a/platform/pulpcore/<wbr>app/viewsets/content.py#L12</a> <br>[2] <a href="https://github.com/pulp/pulp_file/blob/d684f75ea148711f91ea1e1800f44a941275f606/pulp_file/app/viewsets.py#L7" target="_blank">https://github.com/pulp/pulp_<wbr>file/blob/<wbr>d684f75ea148711f91ea1e1800f44a<wbr>941275f606/pulp_file/app/<wbr>viewsets.py#L7</a><br><br></div></div>
<br>______________________________<wbr>_________________<br>
Pulp-dev mailing list<br>
<a href="mailto:Pulp-dev@redhat.com">Pulp-dev@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/<wbr>mailman/listinfo/pulp-dev</a><br>
<br></blockquote></div><br></div>