<div dir="ltr">After meeting with @dkliban and @jortel to discuss #3360, we came up with an alternative proposal that has some small tweaks. Basically, all three parameters (add_content, remove_content, and base_version) could be used together and the parameter for the repository version would be called ‘base_version’. I think the parameter name of base_version make sense because it aligns with the code and since we’re allowing all three parameters to be used in conjunction, the repo version is a sort of base that you build on by adding/removing content.<div><br></div><div>Would like to get people’s thoughts on this alternate proposal.</div></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><br></div><div>David<br></div></div></div></div></div></div></div></div>
<br><div class="gmail_quote">On Mon, Feb 19, 2018 at 12:51 PM, Jeff Ortel <span dir="ltr"><<a href="mailto:jortel@redhat.com" target="_blank">jortel@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<font face="DejaVu Sans">I'm concerned that having a single endpoint
with a complicated combination of parameters that control how the
endpoint behaves isn't ideal. Especially since some of the
parameters are mutually exclusive. Seems that having </font>
/api/v3/repositories/<id>/<wbr>versions/ endpoint do one thing is
cleaner. Should we go with the approach of simpler endpoints, I
would suggest something like
/api/v3/repositories/<id>/<wbr>versions/clone/ that accepts
parameter "version" in the body that is an href to an existing
version. If we go with a single complex endpoint, I'd suggest
"cone_version" as the parameter.<br>
<br>
As an aside, the existing add_content_units and remove_content_units
should be renamed. "_content" is already plural so adding the
"_units" is the singular form that's made plural. Should just be
add_content, remote_content.<div><div class="h5"><br>
<br>
<div class="m_3433305402176796736moz-cite-prefix">On 02/16/2018 03:30 PM, Dennis Kliban
wrote:<br>
</div>
</div></div><blockquote type="cite"><div><div class="h5">
<div dir="ltr">
<div>Earlier today several of us discussed issue 3360[0]. In our
discussion we concluded that it is valuable for users to be
able to create exact copies of repository versions within a
repository and across different repositories. I have updated
the issue to reflect what we discussed. We decided that this
use case should be included in the MVP. <br>
<br>
</div>
The issue currently states that the parameter will be called
'mirror_repository_version'. However, we could not agree if that
is actually the best name for this parameter. Suggestions for a
better name are welcome on this thread or as comments on the
issue. <br>
<div><br>
<br>
[0] <a href="https://pulp.plan.io/issues/3360" target="_blank">https://pulp.plan.io/issues/<wbr>3360</a><br>
<br>
</div>
<div>-Dennis<br>
</div>
</div>
<br>
<fieldset class="m_3433305402176796736mimeAttachmentHeader"></fieldset>
<br>
</div></div><span class=""><pre>______________________________<wbr>_________________
Pulp-dev mailing list
<a class="m_3433305402176796736moz-txt-link-abbreviated" href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a>
<a class="m_3433305402176796736moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/pulp-dev" target="_blank">https://www.redhat.com/<wbr>mailman/listinfo/pulp-dev</a>
</pre>
</span></blockquote>
<br>
</div>
<br>______________________________<wbr>_________________<br>
Pulp-dev mailing list<br>
<a href="mailto:Pulp-dev@redhat.com">Pulp-dev@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/<wbr>mailman/listinfo/pulp-dev</a><br>
<br></blockquote></div><br></div>