<div dir="ltr"><div>FWIW, I've looked them over and think they're good, but given the +/- 1's discussion on IRC, you may want to get further grooming consensus still.<br><br></div>--Dana<br></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div>
<p style="font-weight:bold;margin:0;padding:0;font-size:14px;text-transform:uppercase;margin-bottom:0"><span>Dana</span> <span>Walker</span></p>
<p style="font-weight:normal;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><span>Associate Software Engineer</span><span style="font-weight:normal;color:#aaa;margin:0"></span></p>
<p style="font-weight:normal;margin:0;font-size:10px;color:#999"><a style="color:#0088ce;font-size:10px;margin:0;text-decoration:none;font-family:'overpass',sans-serif" href="https://www.redhat.com" target="_blank">Red Hat <span><br><br></span></a></p>
<table border="0"><tbody><tr><td width="100px"><a href="https://red.ht/sig" target="_blank"> <img src="https://www.redhat.com/files/brand/email/sig-redhat.png" width="90" height="auto"></a> </td>
</tr></tbody></table>
</div></div></div></div>
<br><div class="gmail_quote">On Fri, Mar 23, 2018 at 1:51 PM, Austin Macdonald <span dir="ltr"><<a href="mailto:amacdona@redhat.com" target="_blank">amacdona@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Would anyone mind grooming these? Also, last change to shut it down :)<div><a href="https://pulp.plan.io/issues/3488" target="_blank">https://pulp.plan.io/issues/<wbr>3488</a><br></div><div><a href="https://pulp.plan.io/issues/3492" target="_blank">https://pulp.plan.io/issues/<wbr>3492</a><br></div><div><br></div><div><br></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Mar 16, 2018 at 9:27 AM, Austin Macdonald <span dir="ltr"><<a href="mailto:amacdona@redhat.com" target="_blank">amacdona@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Ive created tasks to do this work. <div><br></div><div>Rename:</div><div><a href="https://pulp.plan.io/issues/3488" target="_blank">https://pulp.plan.io/issues/34<wbr>88</a><br></div><div><br></div><div>Move sync_mode, remove download_policy</div><div><a href="https://pulp.plan.io/issues/3492" target="_blank">https://pulp.plan.io/issues/34<wbr>92</a><br></div><div><br></div><div>Each of these has corresponding plugin tasks, which are related to them.</div></div><div class="m_-8447907303269340806HOEnZb"><div class="m_-8447907303269340806h5"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Mar 15, 2018 at 4:16 PM, David Davis <span dir="ltr"><<a href="mailto:daviddavis@redhat.com" target="_blank">daviddavis@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Austin and Jeff,<div><br></div><div>Thanks for the responses. I am happy with moving forward and opening an issue in redmine for this change</div><div><br></div><div>I think I am +0 on dropping the fields. However, if we start to get complaints from our users, I think we should consider adding them back.</div><div class="gmail_extra"><span class="m_-8447907303269340806m_-9220544353171126330HOEnZb"><font color="#888888"><br clear="all"><div><div class="m_-8447907303269340806m_-9220544353171126330m_104394489994098558m_-5641913301858728280gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><br></div><div>David<br></div></div></div></div></div></div></div></div></font></span><div><div class="m_-8447907303269340806m_-9220544353171126330h5">
<br><div class="gmail_quote">On Wed, Mar 14, 2018 at 10:16 AM, Jeff Ortel <span dir="ltr"><<a href="mailto:jortel@redhat.com" target="_blank">jortel@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<font face="DejaVu Sans">In pulp3, users need to keep track for a
number of things. For example, without auto publish, users need
to keep track of which importer(s) and publishers need to be used
for sync/publish workflows. I fully expect that users using the
API will be maintaining some kind of automation/</font><font face="DejaVu Sans"><font face="DejaVu Sans"><font face="DejaVu
Sans"><font face="DejaVu Sans">orchestration</font></font></font>
on their end (shell scripts, ansible). </font><font face="DejaVu
Sans"><font face="DejaVu Sans">So, keeping track of sync and
download policies does not seem like much of a burden. Also,
after further consideration, I don't think that storing either
the sync (mode) or download policy on the repository is
appropriate. <br>
</font></font><div><div class="m_-8447907303269340806m_-9220544353171126330m_104394489994098558m_-5641913301858728280h5"><font face="DejaVu Sans"><font face="DejaVu Sans"><font face="DejaVu Sans"><font face="DejaVu Sans"><font face="DejaVu
Sans"> </font></font></font></font><br>
<br>
</font>
<div class="m_-8447907303269340806m_-9220544353171126330m_104394489994098558m_-5641913301858728280m_4169656699768001502moz-cite-prefix">On 03/13/2018 04:59 PM, David Davis
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Can you elaborate on what made you reconsider?
Asking because I still see the point that you and Justin raised
about dropping the fields as an issue.
<div class="gmail_extra"><br clear="all">
<div>
<div class="m_-8447907303269340806m_-9220544353171126330m_104394489994098558m_-5641913301858728280m_4169656699768001502m_2372617563978262800gmail_signature" data-smartmail="gmail_signature">
<div dir="ltr">
<div>
<div dir="ltr">
<div>
<div dir="ltr">
<div><br>
</div>
<div>David<br>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<br>
<div class="gmail_quote">On Mon, Mar 12, 2018 at 12:31 PM,
Jeff Ortel <span dir="ltr"><<a href="mailto:jortel@redhat.com" target="_blank">jortel@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<div>
<div class="m_-8447907303269340806m_-9220544353171126330m_104394489994098558m_-5641913301858728280m_4169656699768001502m_2372617563978262800h5"> <br>
<br>
<div class="m_-8447907303269340806m_-9220544353171126330m_104394489994098558m_-5641913301858728280m_4169656699768001502m_2372617563978262800m_-1098806198985260823moz-cite-prefix">On
03/12/2018 10:28 AM, Jeff Ortel wrote:<br>
</div>
<blockquote type="cite"> On 03/08/2018 10:13 AM,
Austin Macdonald wrote:<br>
<blockquote type="cite">
<div dir="ltr">Motivation:
<div>The name "importer" carries some
inaccurate implications. </div>
<div>1) Importers should "import". Tasks like
"sync" will do the actual importing. The
object only holds the configuration that
happens to be used by sync tasks. </div>
<div>2) Sync tasks on mirror mode remove
content as well as add it, so "import" isn't
quite right.</div>
<div><br>
</div>
<div>Proposed name: Remote</div>
<div><br>
</div>
<div>The inspiration for remote is "git
remote". In git, remotes represent external
repositories, which is almost exactly what
our importers do. <br>
</div>
</div>
</blockquote>
<br>
+1, The git/ostree "remote" concept applies very
well to most of what an "importer" defines in
pulp.<br>
<br>
<blockquote type="cite">
<div dir="ltr">
<div><br>
</div>
<div>------------------------------<wbr>-------------------------</div>
<div>Part 2: Trim the fields</div>
<div><br>
</div>
<div>Currently, Importers have settings that
can be categorized in 2 ways. I am proposing
removing the "sync settings" from the Remote
model:</div>
<div><br>
</div>
<div>External Source information</div>
<div> name<br>
</div>
<div>
<div> feed_url</div>
<div> validate</div>
<div> ssl_ca_certificate</div>
<div> ssl_client_certificate</div>
<div> ssl_client_key</div>
<div> ssl_validation</div>
<div> proxy_url</div>
<div> username</div>
<div> password</div>
<div><br>
</div>
<div>Sync settings</div>
<div> download_policy</div>
<div> sync_mode</div>
<div><br>
</div>
<div>This had some advantages when Importers
were related to Repositories. For example,
having a repository.importer that always
used the same sync mode made sense.
However, the "how" to sync settings don't
make much sense when importers and
repositories are not linked. It seems very
reasonable that a user might have 2
repositories that sync from the same
source (ex EPEL). It does not make sense
for them to have create an Importer for
the EPEL repository twice or more just to
change sync_mode or download policy.
Instead of modeling these fields, I
propose that they should POST body
parameters.</div>
</div>
</div>
</blockquote>
<br>
I, as a user, don't like having to specify
download_policy & sync_mode on every
request. The burden on the user to passing these
consistently seems unnecessary and prone to
error. And, like something that pulp should store
as part of it's value proposition. Imagine an
organization with tons of repositories and
admins. They would need to maintain a
spreadsheet, notes, scripts for these settings so
that admin A is syncing using the same settings as
admin B.<br>
<br>
Perhaps download_policy & sync_mode should be
attributes of the repository. Thoughts on moving
them there. The sync_mode (mirror/additive) may
need to be renamed in a way that changes it from
describing how the importer is syning to something
that defines the type of repository. Like that
the repository is intended to be a mirror or not.
Perhaps just a "mirror" (bool) attribute.<br>
</blockquote>
<br>
</div>
</div>
I have reconsidered this. Disregard.<span><br>
<br>
<blockquote type="cite">
<blockquote type="cite">
<div dir="ltr">
<div>
<div><br>
</div>
<div>example</div>
<div> </div>
<div>POST v3/remotes/1234/sync/
repositorty=myrepo_href sync_mode=additive,
dl_policy=immediate</div>
<div>
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial">POST
v3/remotes/1234/sync/
repositorty=myother_href sync_mode=mirror,
dl_policy=deferred </div>
<br class="m_-8447907303269340806m_-9220544353171126330m_104394489994098558m_-5641913301858728280m_4169656699768001502m_2372617563978262800m_-1098806198985260823gmail-Apple-interchange-newline">
</div>
</div>
</div>
<br>
<fieldset class="m_-8447907303269340806m_-9220544353171126330m_104394489994098558m_-5641913301858728280m_4169656699768001502m_2372617563978262800m_-1098806198985260823mimeAttachmentHeader"></fieldset>
<br>
<pre>______________________________<wbr>_________________
Pulp-dev mailing list
<a class="m_-8447907303269340806m_-9220544353171126330m_104394489994098558m_-5641913301858728280m_4169656699768001502m_2372617563978262800m_-1098806198985260823moz-txt-link-abbreviated" href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a>
<a class="m_-8447907303269340806m_-9220544353171126330m_104394489994098558m_-5641913301858728280m_4169656699768001502m_2372617563978262800m_-1098806198985260823moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/pulp-dev" target="_blank">https://www.redhat.com/mailman<wbr>/listinfo/pulp-dev</a>
</pre>
</blockquote>
<br>
</blockquote>
<br>
</span></div>
<br>
______________________________<wbr>_________________<br>
Pulp-dev mailing list<br>
<a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman<wbr>/listinfo/pulp-dev</a><br>
<br>
</blockquote>
</div>
<br>
</div>
</div>
</blockquote>
<br>
</div></div></div>
</blockquote></div><br></div></div></div></div>
<br>______________________________<wbr>_________________<br>
Pulp-dev mailing list<br>
<a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman<wbr>/listinfo/pulp-dev</a><br>
<br></blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div><br>______________________________<wbr>_________________<br>
Pulp-dev mailing list<br>
<a href="mailto:Pulp-dev@redhat.com">Pulp-dev@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/<wbr>mailman/listinfo/pulp-dev</a><br>
<br></blockquote></div><br></div>