<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<br>
<div class="moz-cite-prefix">On 04/09/2018 02:18 PM, Austin
Macdonald wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CA+Kyt=qbXRKbMkGFB-Q+NGf9i5KG91gLfcrHzqtKx7F8vES+=A@mail.gmail.com">
<div dir="ltr">
<div>Folks,</div>
<div><br>
</div>
<div>Austin, Dennis, and Milan have identified the following
issues with current Pulp3 REST API design:</div>
<div>
<ul>
<li>Action endpoints are problematic.<br>
</li>
<ul>
<li>Example POST@/importers/<plugin>/sync/</li>
<li>They are non-RESTful and would make client code
tightly coupled with the server code.</li>
<li>These endpoints are inconsistent with the other parts
of the REST API.</li>
<li>DRF is not being used as intended for action endpoints
so we have to implement extra code. (against the grain)</li>
</ul>
</ul>
</div>
</div>
</blockquote>
+1 <br>
<br>
<blockquote type="cite"
cite="mid:CA+Kyt=qbXRKbMkGFB-Q+NGf9i5KG91gLfcrHzqtKx7F8vES+=A@mail.gmail.com">
<div dir="ltr">
<div>
<ul>
<li>We don't have a convention for where plug-in-specific,
custom repository version creation endpoints.<br>
</li>
<ul>
<li>example POST@/api/v3/<where?>/docker/<wbr>add/</li>
<li>needs to be discoverable through the schema</li>
</ul>
</ul>
</div>
</div>
</blockquote>
<br>
+1<br>
<br>
<blockquote type="cite"
cite="mid:CA+Kyt=qbXRKbMkGFB-Q+NGf9i5KG91gLfcrHzqtKx7F8vES+=A@mail.gmail.com">
<div dir="ltr">
<div>
<ul>
<li>For direct repository version creation, plugins are not
involved.<br>
</li>
<ul>
<li>validation correctness problem: <a
href="https://pulp.plan.io/issues/3541"
target="_blank" moz-do-not-send="true">https://pulp.plan.io/issues/<wbr>3541</a></li>
<li>example: POST@/api/v3/repositories/<<wbr>repository_id>/versions/</li>
</ul>
</ul>
</div>
</div>
</blockquote>
<br>
Looks like half of the plugins will need to participate in creating
repository versions (outside of sync). The API design should take a
consistent approach to creating repository versions (<i>add</i> <u>and</u>
<i>sync</i>).<br>
<br>
<blockquote type="cite"
cite="mid:CA+Kyt=qbXRKbMkGFB-Q+NGf9i5KG91gLfcrHzqtKx7F8vES+=A@mail.gmail.com">
<div dir="ltr">
<div>We would like to get feedback on these issues being sound
and worth resolving before we resume particular solution
discussion[1].</div>
<div><br>
</div>
<div>Thanks,</div>
<div>Austin, Dennis, and Milan</div>
<div><br>
</div>
<div>[1] <a
href="https://www.redhat.com/archives/pulp-dev/2018-March/msg00066.html"
target="_blank" moz-do-not-send="true">https://www.redhat.com/<wbr>archives/pulp-dev/2018-March/<wbr>msg00066.html</a><br>
</div>
<div><br>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Pulp-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Pulp-dev@redhat.com">Pulp-dev@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/pulp-dev">https://www.redhat.com/mailman/listinfo/pulp-dev</a>
</pre>
</blockquote>
<br>
</body>
</html>