<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Apr 23, 2018 at 1:45 PM, Jeremy Audet <span dir="ltr"><<a href="mailto:jaudet@redhat.com" target="_blank">jaudet@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Thanks for answering my questions, all.<br><br></div><span><div><span class="m_6936964047669119140m_-1467377575859631982gmail-im"><div><span style="font-size:12.8px">> > </span><span style="font-size:12.8px">Let's say pulp_file is being tested. Is both it and pulpcore installed from source? Or is pulpcore installed from egg/wheel?</span></div><div><span style="font-size:12.8px">><br></span></div></span><div><span style="font-size:12.8px">> Yes,
we’re testing against source which also allows us to test against
different PRs. Often, a pulpcore change will require a pulp_file change
or vice versa and we just added some functionality recently that
actually lets us test against PRs too.[1] pulp-smash is also running
against source or PRs. IMO, testing against source lets us move faster
than testing against releases. Maybe we can look at switching though
once things have stabilized after the MVP.</span></div><br></div></span><div>This seems fine in most cases. But when verifying whether a plugin can be made into a wheel, this seems like a bad strategy. A brand new wheel should work well when installed alongside other wheels from PyPI, and testing against from-source installations gives no assurance that this is so.<br></div></div>
<br></blockquote><div><br></div><div>That is a great observation. When we automate releasing pulp_file or another plugin to PyPI using Travis, we will make sure to run tests against an already published build of pulpcore. <br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">______________________________<wbr>_________________<br>
Pulp-dev mailing list<br>
<a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman<wbr>/listinfo/pulp-dev</a><br>
<br></blockquote></div><br></div></div>