<div dir="ltr">+1<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jun 18, 2018 at 3:14 PM, Dana Walker <span dir="ltr"><<a href="mailto:dawalker@redhat.com" target="_blank">dawalker@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>+1</div><div><br></div><div>(Already said it during review, but figured I'd make it official here.)<br></div></div><div class="gmail_extra"><br clear="all"><div><div class="m_-4678794260669350850gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div> <p style="font-weight:bold;margin:0;padding:0;font-size:14px;text-transform:uppercase;margin-bottom:0"><span>Dana</span> <span>Walker</span></p> <p style="font-weight:normal;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><span>Associate Software Engineer</span><span style="font-weight:normal;color:#aaa;margin:0"></span></p> <p style="font-weight:normal;margin:0;font-size:10px;color:#999"><a style="color:#0088ce;font-size:10px;margin:0;text-decoration:none;font-family:'overpass',sans-serif" href="https://www.redhat.com" target="_blank">Red Hat <span><br><br></span></a></p> <table border="0"><tbody><tr><td width="100px"><a href="https://red.ht/sig" target="_blank"> <img src="https://www.redhat.com/files/brand/email/sig-redhat.png" width="90" height="auto"></a> </td> </tr></tbody></table> </div></div></div></div><div><div class="h5"> <br><div class="gmail_quote">On Mon, Jun 18, 2018 at 2:01 PM, Daniel Alley <span dir="ltr"><<a href="mailto:dalley@redhat.com" target="_blank">dalley@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">+1<br></div><div class="m_-4678794260669350850HOEnZb"><div class="m_-4678794260669350850h5"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jun 18, 2018 at 12:16 PM, Brian Bouterse <span dir="ltr"><<a href="mailto:bbouters@redhat.com" target="_blank">bbouters@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>+1<br></div></div><div class="m_-4678794260669350850m_-7924896398593226506HOEnZb"><div class="m_-4678794260669350850m_-7924896398593226506h5"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jun 18, 2018 at 8:47 AM, Ina Panova <span dir="ltr"><<a href="mailto:ipanova@redhat.com" target="_blank">ipanova@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">+1<br></div><div class="gmail_extra"><br clear="all"><div><div class="m_-4678794260669350850m_-7924896398593226506m_308465776740741682m_7636621129838803589gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><br><br>--------<br>Regards,<br><br>Ina Panova<br>Software Engineer| Pulp| Red Hat Inc.<br><br>"Do not go where the path may lead,<br> go instead where there is no path and leave a trail."<br></div></div></div><div><div class="m_-4678794260669350850m_-7924896398593226506m_308465776740741682h5"> <br><div class="gmail_quote">On Thu, Jun 14, 2018 at 10:19 PM, Bihan Zhang <span dir="ltr"><<a href="mailto:bizhang@redhat.com" target="_blank">bizhang@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">+1<div>I think the plugin_template is very valuable for bootstrapping plugin development, but we have had issues with keeping it up to date. Creating a smash test that will enforce this on new PRs make perfect sense to me. </div><div><br></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="m_-4678794260669350850m_-7924896398593226506m_308465776740741682m_7636621129838803589h5">On Thu, Jun 14, 2018 at 11:29 AM, Austin Macdonald <span dir="ltr"><<a href="mailto:austin@redhat.com" target="_blank">austin@redhat.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="m_-4678794260669350850m_-7924896398593226506m_308465776740741682m_7636621129838803589h5"><div dir="ltr"><div>I've recently updated the plugin_template to work with the latest <br></div><div>master (3.0). [0] The template handles almost all of the bootstrapping</div><div> work necessary to write a new plugin, so it is valuable to keep it up to</div><div> date. Given human nature, it's likely that the plugin_template will tend <br></div><div>to fall behind as it did recently. I have some ideas to save time while <br></div><div>keeping the template current and useful.<br></div><br><div>1) Move the plugin writer docs [1] into the plugin_template repository</div><div> - Leave a (very) high level overview in the core docs with a link to</div><div> the template docs.<br></div><div> - Plugin writer docs PRs would only go to one place, and it would</div><div> be easier keep the docs in line with the code.<br></div><div> - Narrative docs in the template would explain what needs to be <br></div><div> done generally, linking to the modules.<br></div><div> - Specific instructions would live in the code modules alongside <br></div><div> basic working code, and additional commented out code</div><div> to demonstrate and explain more complex behaviors.</div><div><br></div><div> 2) Add pulp_smash tests for basic functionality of a bootstrapped plugin.<br></div><div> - Run these tests as a check on pulpcore and template PRs<br></div><div> - Ensure that discoverability works</div><div><div> - Fail with breaking Plugin API changes</div><div> - If the test uses pulp_smash, it would include a base set of</div><div> integration tests for every new plugin.<br></div><br></div><div>My reasoning is that no matter what changes we make to pulpcore,</div><div>we need to keep the plugin writer docs updated. Doing this in the</div><div>template will provide value for plugin writers, and will inform pulpcore</div><div> developers when it needs to be updated.<br></div><div><br></div><div>[0]: <a href="https://github.com/pulp/plugin_template/pull/9" target="_blank">https://github.com/pulp/plugin<wbr>_template/pull/9</a><br></div><div>[1]: <a href="https://github.com/pulp/pulp/tree/master/docs/plugins/plugin-writer" target="_blank">https://github.com/pulp/pulp/t<wbr>ree/master/docs/plugins/plugin<wbr>-writer</a><div class="m_-4678794260669350850m_-7924896398593226506m_308465776740741682m_7636621129838803589m_13412176787327362m_-8711202684329256124m_-5478358523845238607gmail-yj6qo"></div><div class="m_-4678794260669350850m_-7924896398593226506m_308465776740741682m_7636621129838803589m_13412176787327362m_-8711202684329256124m_-5478358523845238607gmail-adL"><br></div></div><br></div> <br></div></div>______________________________<wbr>_________________<br> Pulp-dev mailing list<br> <a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br> <a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman<wbr>/listinfo/pulp-dev</a><br> <br></blockquote></div><br></div> <br>______________________________<wbr>_________________<br> Pulp-dev mailing list<br> <a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br> <a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman<wbr>/listinfo/pulp-dev</a><br> <br></blockquote></div><br></div></div></div> <br>______________________________<wbr>_________________<br> Pulp-dev mailing list<br> <a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br> <a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman<wbr>/listinfo/pulp-dev</a><br> <br></blockquote></div><br></div> </div></div><br>______________________________<wbr>_________________<br> Pulp-dev mailing list<br> <a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br> <a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman<wbr>/listinfo/pulp-dev</a><br> <br></blockquote></div><br></div> </div></div><br>______________________________<wbr>_________________<br> Pulp-dev mailing list<br> <a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br> <a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman<wbr>/listinfo/pulp-dev</a><br> <br></blockquote></div><br></div></div></div> <br>______________________________<wbr>_________________<br> Pulp-dev mailing list<br> <a href="mailto:Pulp-dev@redhat.com">Pulp-dev@redhat.com</a><br> <a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/<wbr>mailman/listinfo/pulp-dev</a><br> <br></blockquote></div><br></div>