<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<font size="-1"><font face="DejaVu Sans">+1</font></font><br>
<br>
<div class="moz-cite-prefix">On 07/10/2018 02:30 PM, David Davis
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAHa=2WnkeRvGQ6ZQw5iJErFajMTwhMYXAwUK6-GiRK0=oLb+hw@mail.gmail.com">
<div dir="ltr">We noticed in Pulp that the 2-master branch has
branch protection but only to prevent force pushes and deletion.
I was wondering if we should also add these checks:
<div><br>
</div>
<div>- Require an approving review</div>
<div>- Require status checks (e.g. unit tests, docs test,
flake8)
<div><br>
</div>
<div>If so, I think we should also do this for all master and
2-master branches for all Pulp core repos (where
applicable). Does anyone have any thoughts or objections?</div>
<div><br>
</div>
<div>I’ll leave this discussion open until July 22, 2018.</div>
<div>
<div>
<div dir="ltr" class="gmail_signature"
data-smartmail="gmail_signature">
<div dir="ltr">
<div>
<div dir="ltr">
<div>
<div dir="ltr">
<div><br>
</div>
<div>David<br>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<!--'"--><br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Pulp-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Pulp-dev@redhat.com">Pulp-dev@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/pulp-dev">https://www.redhat.com/mailman/listinfo/pulp-dev</a>
</pre>
</blockquote>
<br>
</body>
</html>