<div dir="ltr">+1<br></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><br><br>--------<br>Regards,<br><br>Ina Panova<br>Software Engineer| Pulp| Red Hat Inc.<br><br>"Do not go where the path may lead,<br> go instead where there is no path and leave a trail."<br></div></div></div>
<br><div class="gmail_quote">On Tue, Jul 10, 2018 at 11:31 PM, Jeff Ortel <span dir="ltr"><<a href="mailto:jortel@redhat.com" target="_blank">jortel@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<font size="-1"><font face="DejaVu Sans">+1</font></font><div><div class="h5"><br>
<br>
<div class="m_2070205076768295018moz-cite-prefix">On 07/10/2018 02:30 PM, David Davis
wrote:<br>
</div>
</div></div><blockquote type="cite"><div><div class="h5">
<div dir="ltr">We noticed in Pulp that the 2-master branch has
branch protection but only to prevent force pushes and deletion.
I was wondering if we should also add these checks:
<div><br>
</div>
<div>- Require an approving review</div>
<div>- Require status checks (e.g. unit tests, docs test,
flake8)
<div><br>
</div>
<div>If so, I think we should also do this for all master and
2-master branches for all Pulp core repos (where
applicable). Does anyone have any thoughts or objections?</div>
<div><br>
</div>
<div>I’ll leave this discussion open until July 22, 2018.</div>
<div>
<div>
<div dir="ltr" class="m_2070205076768295018gmail_signature" data-smartmail="gmail_signature">
<div dir="ltr">
<div>
<div dir="ltr">
<div>
<div dir="ltr">
<div><br>
</div>
<div>David<br>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<br>
<fieldset class="m_2070205076768295018mimeAttachmentHeader"></fieldset>
<br>
</div></div><span class=""><pre>______________________________<wbr>_________________
Pulp-dev mailing list
<a class="m_2070205076768295018moz-txt-link-abbreviated" href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a>
<a class="m_2070205076768295018moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/pulp-dev" target="_blank">https://www.redhat.com/<wbr>mailman/listinfo/pulp-dev</a>
</pre>
</span></blockquote>
<br>
</div>
<br>______________________________<wbr>_________________<br>
Pulp-dev mailing list<br>
<a href="mailto:Pulp-dev@redhat.com">Pulp-dev@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/<wbr>mailman/listinfo/pulp-dev</a><br>
<br></blockquote></div><br></div>