<div dir="ltr"><div>+1</div><div><br></div><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div>
<p style="font-weight:bold;margin:0;padding:0;font-size:14px;text-transform:uppercase;margin-bottom:0"><span>Dana</span> <span>Walker</span></p>
<p style="font-weight:normal;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><span>Associate Software Engineer</span><span style="font-weight:normal;color:#aaa;margin:0"></span></p>
<p style="font-weight:normal;margin:0;font-size:10px;color:#999"><a style="color:#0088ce;font-size:10px;margin:0;text-decoration:none;font-family:'overpass',sans-serif" href="https://www.redhat.com" target="_blank">Red Hat <span><br><br></span></a></p>
<table border="0"><tbody><tr><td width="100px"><a href="https://red.ht/sig" target="_blank"> <img src="https://www.redhat.com/files/brand/email/sig-redhat.png" width="90" height="auto"></a> </td>
</tr></tbody></table>
</div></div></div></div><br></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Dec 4, 2018 at 1:52 PM Tatiana Tereshchenko <<a href="mailto:ttereshc@redhat.com">ttereshc@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">+1<br></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Dec 4, 2018 at 4:49 PM Brian Bouterse <<a href="mailto:bbouters@redhat.com" target="_blank">bbouters@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">+1. Ty for bringing this up <a class="gmail_plusreply" id="m_-8706903153538071029m_2892025036073659181plusReplyChip-2">@dalley</a><br></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Dec 4, 2018 at 10:47 AM Jeff Ortel <<a href="mailto:jortel@redhat.com" target="_blank">jortel@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
no objection<br>
<br>
<div class="m_-8706903153538071029m_2892025036073659181m_1068728093239399446moz-cite-prefix">On 12/3/18 10:32 PM, Daniel Alley
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div><b>Background:</b></div>
<div><br>
</div>
<div>"Notes" are a generic key value store where data can be
attached to repositories and content and publications and so
forth. The eventual plan is to use this to enable adding tags
to those sorts of objects, which is important for Katello.</div>
<div><br>
</div>
<div>Most of the code for this is located in
pulp/app/models/generic.py<br>
</div>
<div><br>
</div>
<div><b>Motivation:</b></div>
<div><br>
</div>
<div>"Notes" have been in Pulp 3 for a very very long time and
are completely unchanged for the last 12 months (the git
history doesn't go back further because the file was moved).
The data model behind it is extremely complex and while we
have a few unit tests around it, we have no functional tests
for it whatsoever, and (to my knowledge) we haven't been
using/exercising this functionality manually in a meaningful
way (if at all). I could be wrong here, but I haven't seen it
discussed or any issues related to it filed in quite some
time.<br>
</div>
<br>
<div><b>Proposal:</b><br>
</div>
<div><br>
</div>
<div>We should pull out all of the "notes" code
(models/generic.py + the fields on the aforementioned models)
until we've had a chance to properly evaluate our needs and
whether the current design fits them.</div>
</div>
<br>
<fieldset class="m_-8706903153538071029m_2892025036073659181m_1068728093239399446mimeAttachmentHeader"></fieldset>
<pre class="m_-8706903153538071029m_2892025036073659181m_1068728093239399446moz-quote-pre">_______________________________________________
Pulp-dev mailing list
<a class="m_-8706903153538071029m_2892025036073659181m_1068728093239399446moz-txt-link-abbreviated" href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a>
<a class="m_-8706903153538071029m_2892025036073659181m_1068728093239399446moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/pulp-dev" target="_blank">https://www.redhat.com/mailman/listinfo/pulp-dev</a>
</pre>
</blockquote>
<br>
</div>
_______________________________________________<br>
Pulp-dev mailing list<br>
<a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br>
</blockquote></div>
_______________________________________________<br>
Pulp-dev mailing list<br>
<a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br>
</blockquote></div>
_______________________________________________<br>
Pulp-dev mailing list<br>
<a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br>
</blockquote></div>