<div dir="ltr">@David Davis The URL generation code doesn't make any assumptions, it looks up the view name for the model and then fetches the URL associated with that view using reverse(). It doesn't matter where the plugin writer puts their URLs.<br><div><br></div><div>@Dennis Do we still want to have counts for added and removed? It might be useful.<br></div></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Dec 13, 2018 at 8:18 AM Dennis Kliban <<a href="mailto:dkliban@redhat.com">dkliban@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Let's continue with hte original proposal and keep the URLs. <br></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Dec 12, 2018 at 5:51 PM Brian Bouterse <<a href="mailto:bbouters@redhat.com" target="_blank">bbouters@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">I commented on the PR that I think we should include the URLs and here's the reasoning: <a href="https://github.com/pulp/pulp/pull/3774#issuecomment-446633354" target="_blank">https://github.com/pulp/pulp/pull/3774#issuecomment-446633354</a></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Dec 12, 2018 at 5:29 PM Daniel Alley <<a href="mailto:dalley@redhat.com" target="_blank">dalley@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Just thought of something. The URLs for specific content types are at <br> the discretion of the plugin writer so now I'm not convinced the user <br> has a way to reliably construct the URLs themselves.</blockquote><div><br></div><div>Yup, this is my view. The counterargument Dennis has been making is that the user could either A) use the live API docs to find out what URL to hit, B) find it in the hosted docs, or C) use the bindings generated from the schema, the name of the function is documented and you don't need to care about the URL.<br></div><div><br></div><div>I suppose it depends on exactly how frequently users actually need to view/search on the content present in a repository version. If it's a rare need, then maybe that extra friction is OK. If it is common, it could be a pain point -- or perhaps people will just memorize all the endpoints they need to use and it won't be a big deal, I don't really know.</div><br></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Dec 12, 2018 at 1:14 PM Jeff Ortel <<a href="mailto:jortel@redhat.com" target="_blank">jortel@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 12/10/18 1:06 PM, Jeff Ortel wrote:<br> > +1 to counts instead of URLs. The URLs are documented and can be <br> > constructed to listing them on the serialized version does not seem to <br> > add much value. The counts would likely provide more useful <br> > information and consistent with the summary counts.<br> <br> Just thought of something. The URLs for specific content types are at <br> the discretion of the plugin writer so now I'm not convinced the user <br> has a way to reliably construct the URLs themselves.<br> <br> ><br> > On 12/7/18 1:30 PM, Dennis Kliban wrote:<br> >> What if instead the API returned the number of each content type <br> >> added or removed. So a repository version response would look like:<br> >><br> >> {'base_version': None,<br> >> 'content_added': {'pulp_file.file': 4},<br> >> 'content_removed': {'pulp_file.file': 1},<br> >> 'content_summary': {'pulp_file.file': '3'},<br> >> 'created': datetime.datetime(2018, 12, 5, 23, 34, 26, 948749, <br> >> tzinfo=tzlocal()),<br> >> 'href': '/pulp/api/v3/repositories/4/versions/1/',<br> >> 'number': 1}<br> >><br> >> Thoughts?<br> ><br> <br> _______________________________________________<br> Pulp-dev mailing list<br> <a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br> <a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br> </blockquote></div> _______________________________________________<br> Pulp-dev mailing list<br> <a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br> <a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br> </blockquote></div> _______________________________________________<br> Pulp-dev mailing list<br> <a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br> <a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br> </blockquote></div> </blockquote></div>