<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<br>
<div class="moz-cite-prefix">On 1/9/19 11:30 AM, Tatiana
Tereshchenko wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAM0kQbDFLwRoW7bTnqWHdMR3KeZGczgArg1O4tJecZA2uy0PjA@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div>To summarize where we are so far:</div>
<div><b>All</b> master/detail related endpoints will be
automatically prepended with Django app <b>label</b>
[0]<br>
</div>
<div> - concerns: 'pulp_' in the label</div>
<div> - options to address concerns:</div>
<div> * introduce a new attribute to the AppConfig
class to use in the endpoints construction (not
supported by majority so far)</div>
<div> * drop 'pulp_' part from a <b>plugin's</b>
app label (supported by majority so far)</div>
<div><br>
</div>
<div>Questions/concerns about dropping the 'pulp_' from
the plugins' app label:</div>
<div><br>
</div>
<div># Table names in the DB are prepended using the app
label. We need to be sure to avoid collisions with other
applications for pulpcore and for pulp plugins. Are they
already in the "pulp" database?<br>
</div>
<div>Yes, all pulpcore and pulp plugin tables are in
"pulp" database.</div>
<div><br>
</div>
<div># The names in the list of installed plugins would
then not be the same as the packages themselves.</div>
<div>It's probably ok. The status would look like this:</div>
<div> {<br>
"component": "<b>file</b>",<br>
"version": "0.0.1b6"<br>
},<br>
{<br>
"component": "<b>rpm</b>",<br>
"version": "3.0.0b1"</div>
<div> }</div>
<div><br>
</div>
<div># What about the label for the core? (not discussed)<br>
</div>
<div>It stays as is - 'pulp_app'.<br>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<br>
Why? Seems like 'core' would be more descriptive.<br>
<blockquote type="cite"
cite="mid:CAM0kQbDFLwRoW7bTnqWHdMR3KeZGczgArg1O4tJecZA2uy0PjA@mail.gmail.com">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div><br>
</div>
<div>[0] <a
href="https://docs.djangoproject.com/en/2.1/ref/applications/#django.apps.AppConfig.label"
target="_blank" moz-do-not-send="true">https://docs.djangoproject.com/en/2.1/ref/applications/#django.apps.AppConfig.label</a><br>
</div>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Tue, Jan 8, 2019 at 8:22 PM Daniel Alley
<<a href="mailto:dalley@redhat.com" target="_blank"
moz-do-not-send="true">dalley@redhat.com</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div>I'm not opposed to this plan, I just want to point
out that it would make the status API make slightly
less sense. The names in the list of installed
plugins would then not be the same as the packages
themselves. It's probably close enough as to not be a
problem though.<br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Tue, Jan 8, 2019 at 12:23 PM Austin
Macdonald <<a href="mailto:amacdona@redhat.com"
target="_blank" moz-do-not-send="true">amacdona@redhat.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px
0px 0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div dir="ltr"><br>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Tue, Jan 8, 2019 at 12:12 PM
Brian Bouterse <<a
href="mailto:bbouters@redhat.com"
target="_blank" moz-do-not-send="true">bbouters@redhat.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px
0px 0px 0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div dir="ltr">My understanding is that it's for
both. It would be dropped from app_label and
that will automatically be used in
master/detail urls. Is that what others
thought?<br>
</div>
<br>
</blockquote>
<div>This seems like the simplest approach to me.
My only concern with this approach is making
sure that the database will be properly
namespaced so there won't be collisions with
other applications that use postgres like
Katello. AFAIK, the plugin tables don't need to
be namespaced since they are already in the
"pulp" database. Is that correct? If so, +1.<br>
</div>
</div>
</div>
_______________________________________________<br>
Pulp-dev mailing list<br>
<a href="mailto:Pulp-dev@redhat.com" target="_blank"
moz-do-not-send="true">Pulp-dev@redhat.com</a><br>
<a
href="https://www.redhat.com/mailman/listinfo/pulp-dev"
rel="noreferrer" target="_blank"
moz-do-not-send="true">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br>
</blockquote>
</div>
_______________________________________________<br>
Pulp-dev mailing list<br>
<a href="mailto:Pulp-dev@redhat.com" target="_blank"
moz-do-not-send="true">Pulp-dev@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/pulp-dev"
rel="noreferrer" target="_blank" moz-do-not-send="true">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br>
</blockquote>
</div>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
Pulp-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Pulp-dev@redhat.com">Pulp-dev@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/pulp-dev">https://www.redhat.com/mailman/listinfo/pulp-dev</a>
</pre>
</blockquote>
<br>
</body>
</html>