<div dir="ltr"><div>Seems like there are usecases where flake8 might be handy. Let's keep it for now.</div><div>We can always drop it later, after people get more used to black.<br></div><div><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><br><br>--------<br>Regards,<br><br>Ina Panova<br>Senior Software Engineer| Pulp| Red Hat Inc.<br><br>"Do not go where the path may lead,<br> go instead where there is no path and leave a trail."<br></div></div></div></div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jun 27, 2019 at 9:24 PM David Davis <<a href="mailto:daviddavis@redhat.com">daviddavis@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Flake8 is a wrapper for pycodestyle, pyflakes, and mccabe. We probably could just use the last two without pycodestyle. That said I lean toward just keeping flake8 I suppose. It makes some of the configuration stuff easy. <br clear="all"><div><div dir="ltr" class="gmail-m_7288223912981005290gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><br></div><div>David<br></div></div></div></div></div></div></div></div><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jun 27, 2019 at 3:12 PM Bruno Rocha <<a href="mailto:brocha@redhat.com" target="_blank">brocha@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>If you set pre-commit hooks it is possible to have flake-8 to be executed automatically after black format.</div><div><br></div><div>example: <a href="https://github.com/rochacbruno/dynaconf/blob/master/.pre-commit-config.yaml#L31" target="_blank">https://github.com/rochacbruno/dynaconf/blob/master/.pre-commit-config.yaml#L31</a></div><div><br></div><div><br></div><div><div><div dir="ltr" class="gmail-m_7288223912981005290gmail-m_-2900754385325025492gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>
<p style="font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:capitalize;font-family:RedHatText,sans-serif">
<span>Bruno</span> <span>Rocha</span><span style="color:rgb(170,170,170);margin:0px"></span>
</p>
<p style="font-weight:normal;margin:0px;font-size:12px;font-family:RedHatText,sans-serif">
<span>Senior Quality Engineer - Cloud Management QE - Pulp Project<br><b>irc</b>: <span>rochacbruno</span></span>
</p>
<p style="font-size:12px;margin:0px;font-family:RedHatText,sans-serif"><span><b>social</b>: <a href="http://about.me/rochacbruno" target="_blank">http://about.me/rochacbruno</a><br></span></p><p style="font-size:12px;margin:0px;font-family:RedHatText,sans-serif"><span>“Progress is the realization of utopia.”</span><br><span></span>
</p>
<div style="margin-top:12px">
<table border="0">
<tbody><tr>
<td width="100px"><a href="https://red.ht/sig" target="_blank"> <img src="https://static.redhat.com/libs/redhat/brand-assets/latest/corp/logo.png" width="90" height="auto"></a> </td>
</tr>
</tbody></table>
</div>
</div></div></div></div></div></div></div></div></div></div></div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jun 27, 2019 at 3:59 PM Simon Baatz <<a href="mailto:gmbnomis@gmail.com" target="_blank">gmbnomis@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Thu, Jun 27, 2019 at 07:58:38AM -0400, David Davis wrote:<br>
> Follow up question to adding support for black: should we drop flake8?<br>
> We shouldn't need it anymore since black is pep8 compliant but I'm<br>
> happy to keep it around at least temporarily if people prefer?<br>
<br>
Please do not drop it. While black is pep8 compliant, flake8 does<br>
more than pure code formatting checks. For example, the<br>
following code is absolutely fine for black:<br>
<br>
import os<br>
<br>
d = {1: 2, 1: 3}<br>
<br>
<br>
flake8 will complain about the unused import and the problem with the<br>
dict keys.<br>
<br>
_______________________________________________<br>
Pulp-dev mailing list<br>
<a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br>
</blockquote></div>
</blockquote></div>
_______________________________________________<br>
Pulp-dev mailing list<br>
<a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br>
</blockquote></div>