<div dir="ltr"><div dir="ltr"> </div> <div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Aug 27, 2019 at 3:04 PM Mike DePaulo <<a href="mailto:mikedep333@redhat.com">mikedep333@redhat.com</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Note that we makemigrations & migrate at pulp-api container start time. And all the containers (e.g., pulp-content) wait on the pulp-api container to do them: <a href="https://github.com/pulp/pulpcore/blob/master/containers/images/pulp/container-assets/pulp-api#L11" rel="noreferrer" target="_blank">https://github.com/pulp/pulpcore/blob/master/containers/images/pulp/container-assets/pulp-api#L11</a> Once I took over the containers, I envisioned both of these as a temporary measure. Presumably there would be a separate spordically-run container to perform migrations. </blockquote><div>Can we continue to have the container stuff "migrate" but not "makemigrations" along with this change in the installer? My goal is to keep the containers and installer consistent. </div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> On Tue, Aug 27, 2019 at 2:41 PM Brian Bouterse <<a href="mailto:bmbouter@redhat.com" target="_blank">bmbouter@redhat.com</a>> wrote: > > Excellent and good catch on the duplicate already on sprint. Yes let's use 5321 as you suggest. I added to that issue that this was announced and scheduled for Sept 3rd. > > If it's still at NEW on the 3rd, I have a reminder to make a PR and merge on that day. Otherwise anyone can make a PR ahead of time and merge on the 3rd. > > On Tue, Aug 27, 2019 at 2:19 PM Austin Macdonald <<a href="mailto:austin@redhat.com" target="_blank">austin@redhat.com</a>> wrote: >> >> This all sounds good to me. FYI, I closed <a href="https://pulp.plan.io/issues/5361" rel="noreferrer" target="_blank">https://pulp.plan.io/issues/5361</a> as a dupe since <a href="https://pulp.plan.io/issues/5321" rel="noreferrer" target="_blank">https://pulp.plan.io/issues/5321</a> has already been added to the sprint. Feel free to use 5361 and close 5321 if you prefer. >> >> On Tue, Aug 27, 2019 at 2:16 PM Brian Bouterse <<a href="mailto:bmbouter@redhat.com" target="_blank">bmbouter@redhat.com</a>> wrote: >>> >>> tl;dr if we make this change on Sept 3rd, the installer won't auto-create migrations anymore. For every change needing a migration, please commit one. >>> >>> # Background >>> We enabled the installer to "auto-create" migrations as a solution to the problem of them changing a crazy amount early on in Pulp3's development. Now the migrations are expected to be checked in and I believe they are for all plugins. This is only a breaking change for a plugin that is missing migrations. >>> >>> # The Problem >>> <a href="https://pulp.plan.io/issues/5361" rel="noreferrer" target="_blank">https://pulp.plan.io/issues/5361</a> This was originally reported by Katello as a P2; I added details to it. >>> >>> # Feedback >>> If there is something better that we should do please suggest it on the issue. If this is a concern or not going to work for you or our users please bring that up anywhere. >>> >>> # Timeline >>> If there are no blocking concerns, I plan to make this change on Tuesday Sept 3rd. >>> >>> Thank you! >>> Brian >>> >>> _______________________________________________ >>> Pulp-dev mailing list >>> <a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a> >>> <a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/pulp-dev</a> > > _______________________________________________ > Pulp-dev mailing list > <a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a> > <a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/pulp-dev</a> -- Mike DePaulo He / Him / His Service Reliability Engineer, Pulp Red Hat IM: mikedep333 GPG: 51745404 </blockquote></div></div>