<div dir="ltr">Thanks for sharing!<div><br></div><div>Tanya</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Oct 1, 2019 at 1:52 PM David Davis <<a href="mailto:daviddavis@redhat.com">daviddavis@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">I've been reading through Google's Code Reviewer Guide and I've found it rather interesting. While reviewing code may seem pretty basic, I have found a couple rather insightful points in their guide. One example is that they recommend sharing positive feedback while reviewing code--too often reviewers focus on what needs to be fixed in PRs. If you have some time, I recommend reading through it.<div><br></div><div><a href="https://google.github.io/eng-practices/review/reviewer/" target="_blank">https://google.github.io/eng-practices/review/reviewer/</a></div><div><br></div><div>By the way, they use a term CL which comes from their use of a Perforce-like version control system. They define it here under Terminology:</div><div><br></div><div><a href="https://google.github.io/eng-practices/" target="_blank">https://google.github.io/eng-practices/</a><br clear="all"><div><div dir="ltr"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><br></div><div>David<br></div></div></div></div></div></div></div></div></div></div>
_______________________________________________<br>
Pulp-dev mailing list<br>
<a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br>
</blockquote></div>