<div dir="ltr">I agree that it makes sense to talk about it next week. I have a few concerns both in favor and against merging the repos that are not expressed on the issue. Let's remove it off the sprint for now.<div><br></div><div><div><div dir="ltr" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>David<br></div></div></div></div></div></div></div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Oct 17, 2019 at 1:13 PM Brian Bouterse <<a href="mailto:bmbouter@redhat.com" target="_blank">bmbouter@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Thank you for sharing your concerns. Let's think it over more.<br></div><div><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Oct 17, 2019 at 12:39 PM Tatiana Tereshchenko <<a href="mailto:ttereshc@redhat.com" target="_blank">ttereshc@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Do I understand correctly, that the suggestion is not to have versioned api at all but document some conventions/expectations between pulpcore releases and plugin API?</div></div></blockquote><div>We could version pulpcore.plugin as 0.1 as we were. It's just that plugins can't use setuptools tooling to declare their compatibility. The pulp plugin loader could check plugin minimum/maximum versions declared at runtime though and disinclude plugins that aren't compatible with the running pulpcore version. That would be a neat upgrade experience actually whenever the pulpcore.plugin version goes to 0.2 which would be backwards incompatible.<br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><br></div>I wonder if there is still a benefit to keep it as a separate package and as-is.</div></blockquote><div>There is a benefit to keeping it as-is. What we have now is slightly more awesome. The amount of problems it creates though is a lot.<br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>I understand that now we need to release both at the same time, however we are in active development now and when things are more stable we might benefit from having it separate.</div></div></blockquote><div>The code imports heavily across the package lines, so I think we'll always have to co-release, which is the pain because you have to wait a long time for Travis to fully retest + release.<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><br></div><div>It sounds like we are back to pulp2 case, where we would need to release the core if any plugin api changes are needed, just this time we organised code better.</div></div></blockquote><div>We could still have a versioned pulpcore.plugin which would be much stronger.<br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><br></div><div>Since we have a meetup next week, does it make sense to discuss it there? Plans on what we want or expect to support and what kind of changes we foresee in this area? Where the plugin api versioning will benefit us?</div><div>I see many +1s, so it might not worth a discussion and maybe I'm the only one who is concerned.</div></div></blockquote><div>I definitely want to talk about concerns. It's a big change. We can delay some to think it over at least, call for more feedback. I was hoping to keep discussion on the list though, even with us meeting in person. The list I think gives inclusivity and record to those who cannot join. We can remove from sprint now?<br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><br></div><div>Tanya</div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Oct 17, 2019 at 5:58 PM David Davis <<a href="mailto:daviddavis@redhat.com" target="_blank">daviddavis@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Done.<br clear="all"><div><div dir="ltr"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><br></div><div>David<br></div></div></div></div></div></div></div></div><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Oct 17, 2019 at 11:49 AM Brian Bouterse <<a href="mailto:bmbouter@redhat.com" target="_blank">bmbouter@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Yes the issue is here: <a href="https://pulp.plan.io/issues/5580" target="_blank">https://pulp.plan.io/issues/5580</a></div><div><br></div><div>If someone else can groom, I'm +1 to adding to sprint and labelling 3.0 blocker.<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Oct 17, 2019 at 11:01 AM David Davis <<a href="mailto:daviddavis@redhat.com" target="_blank">daviddavis@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Any chance we open an issue and get this on the sprint so that we can maybe release this change in RC8?<br clear="all"><div><div dir="ltr"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><br></div><div>David<br></div></div></div></div></div></div></div></div><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Oct 17, 2019 at 10:49 AM Mike DePaulo <<a href="mailto:mikedep333@redhat.com" target="_blank">mikedep333@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr">On Thu, Oct 17, 2019 at 10:25 AM Brian Bouterse <<a href="mailto:bmbouter@redhat.com" target="_blank">bmbouter@redhat.com</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>I put some responses inline. I'm interested in what you think.<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Oct 17, 2019 at 10:10 AM Mike DePaulo <<a href="mailto:mikedep333@redhat.com" target="_blank">mikedep333@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Q: Will both pulpcore & pulpcore-plugin be published on PyPI as 1 package, or as 2?</div></blockquote><div>I had imagined it would be 1. Users wouldn't be able to receive pulpcore.plugin except through an install of the pulpcore==3.y.z itself.</div></div></div></blockquote><div> </div><div>Great, that makes things easier for users' manual installs, and easier for containers/packaging.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><br><div>If so, how will you pip install from a <a href="https://pip.pypa.io/en/stable/reference/pip_install/#id32" target="_blank">pip VCS URL</a>? With #egg=pulpcore , and then #egg=pulpcore-plugin ?</div></div></div></blockquote><div>You wouldn't perform the second one anymore.</div></div></div></blockquote><div><br></div><div><div>Great, that makes things easier for users' manual installs, and easier for containers/packaging.</div><div><br></div><div>-Mike </div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div><br></div><div>-Mike</div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Oct 17, 2019 at 5:17 AM Simon Baatz <<a href="mailto:gmbnomis@gmail.com" target="_blank">gmbnomis@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">+1<br>
<br>
On Wed, Oct 16, 2019 at 03:50:54PM -0400, Mike DePaulo wrote:<br>
>    +1.<br>
> <br>
>    On Wed, Oct 16, 2019 at 3:26 PM Pavel Picka <[1]<a href="mailto:ppicka@redhat.com" target="_blank">ppicka@redhat.com</a>><br>
>    wrote:<br>
> <br>
>    +1<br>
> <br>
>    On Wed, Oct 16, 2019 at 9:23 PM Dana Walker <[2]<a href="mailto:dawalker@redhat.com" target="_blank">dawalker@redhat.com</a>><br>
>    wrote:<br>
> <br>
>    +1, more straightforward<br>
> <br>
>    Dana Walker<br>
> <br>
>    She / Her / Hers<br>
> <br>
>    Software Engineer, Pulp Project<br>
> <br>
>    [3]Red Hat<br>
> <br>
>    [4]<a href="mailto:dawalker@redhat.com" target="_blank">dawalker@redhat.com</a><br>
>    [5][Logo-RedHat-Email.png]<br>
> <br>
>    On Wed, Oct 16, 2019 at 2:55 PM David Davis <[6]<a href="mailto:daviddavis@redhat.com" target="_blank">daviddavis@redhat.com</a>><br>
>    wrote:<br>
> <br>
>    +1<br>
>    David<br>
> <br>
>    On Wed, Oct 16, 2019 at 2:38 PM Daniel Alley <[7]<a href="mailto:dalley@redhat.com" target="_blank">dalley@redhat.com</a>><br>
>    wrote:<br>
> <br>
>    Very Large +1<br>
> <br>
>    On Wed, Oct 16, 2019 at 2:10 PM Brian Bouterse <[8]<a href="mailto:bmbouter@redhat.com" target="_blank">bmbouter@redhat.com</a>><br>
>    wrote:<br>
> <br>
>    Having just released RC7, there are a variety of problems we are<br>
>    dealing with as a result of having pulpcore and pulpcore-plugin being<br>
>    in separate repos. @daviddavis and I were talking, and we want to ask<br>
>    for feedback on merging the code from pulpcore-plugin into pulpcore.<br>
>    I wrote this up as an issue here:  [9]<a href="https://pulp.plan.io/issues/5580" rel="noreferrer" target="_blank">https://pulp.plan.io/issues/5580</a><br>
>    Thanks!<br>
>    Brian<br>
> <br>
>      _______________________________________________<br>
>      Pulp-dev mailing list<br>
>      [10]<a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br>
>      [11]<a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br>
> <br>
>      _______________________________________________<br>
>      Pulp-dev mailing list<br>
>      [12]<a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br>
>      [13]<a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br>
> <br>
>      _______________________________________________<br>
>      Pulp-dev mailing list<br>
>      [14]<a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br>
>      [15]<a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br>
> <br>
>      _______________________________________________<br>
>      Pulp-dev mailing list<br>
>      [16]<a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br>
>      [17]<a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br>
> <br>
>      --<br>
> <br>
>    Pavel Picka<br>
>    Red Hat<br>
> <br>
>      _______________________________________________<br>
>      Pulp-dev mailing list<br>
>      [18]<a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br>
>      [19]<a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br>
> <br>
>    --<br>
> <br>
>    Mike DePaulo<br>
> <br>
>    He / Him / His<br>
> <br>
>    Service Reliability Engineer, Pulp<br>
> <br>
>    [20]Red Hat<br>
> <br>
>    IM: mikedep333<br>
> <br>
>    GPG: 51745404<br>
>    [21][Logo-RedHat-Email.png]<br>
> <br>
> References<br>
> <br>
>    1. mailto:<a href="mailto:ppicka@redhat.com" target="_blank">ppicka@redhat.com</a><br>
>    2. mailto:<a href="mailto:dawalker@redhat.com" target="_blank">dawalker@redhat.com</a><br>
>    3. <a href="https://www.redhat.com/" rel="noreferrer" target="_blank">https://www.redhat.com/</a><br>
>    4. mailto:<a href="mailto:dawalker@redhat.com" target="_blank">dawalker@redhat.com</a><br>
>    5. <a href="https://www.redhat.com/" rel="noreferrer" target="_blank">https://www.redhat.com/</a><br>
>    6. mailto:<a href="mailto:daviddavis@redhat.com" target="_blank">daviddavis@redhat.com</a><br>
>    7. mailto:<a href="mailto:dalley@redhat.com" target="_blank">dalley@redhat.com</a><br>
>    8. mailto:<a href="mailto:bmbouter@redhat.com" target="_blank">bmbouter@redhat.com</a><br>
>    9. <a href="https://pulp.plan.io/issues/5580" rel="noreferrer" target="_blank">https://pulp.plan.io/issues/5580</a><br>
>   10. mailto:<a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br>
>   11. <a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br>
>   12. mailto:<a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br>
>   13. <a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br>
>   14. mailto:<a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br>
>   15. <a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br>
>   16. mailto:<a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br>
>   17. <a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br>
>   18. mailto:<a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br>
>   19. <a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br>
>   20. <a href="https://www.redhat.com/" rel="noreferrer" target="_blank">https://www.redhat.com/</a><br>
>   21. <a href="https://www.redhat.com/" rel="noreferrer" target="_blank">https://www.redhat.com/</a><br>
<br>
> _______________________________________________<br>
> Pulp-dev mailing list<br>
> <a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br>
> <a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr"><div dir="ltr"><p style="color:rgb(0,0,0);font-family:RedHatText,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:capitalize"><span>Mike</span> <span>DePaulo</span><span style="text-transform:uppercase;color:rgb(170,170,170);margin:0px"></span></p><p style="color:rgb(0,0,0);font-family:RedHatText,sans-serif;font-size:12px;margin:0px 0px 4px;text-transform:capitalize">He / Him / His</p><p style="color:rgb(0,0,0);font-family:RedHatText,sans-serif;font-size:12px;margin:0px;text-transform:capitalize"><span>Service Reliability Engineer, Pulp</span></p><p style="color:rgb(0,0,0);font-family:RedHatText,sans-serif;margin:0px 0px 4px;font-size:12px"><a href="https://www.redhat.com/" style="color:rgb(0,136,206);margin:0px" target="_blank">Red Hat<span></span></a></p><div style="color:rgb(0,0,0);font-family:RedHatText,sans-serif;font-size:medium;margin-bottom:4px"></div><p style="color:rgb(0,0,0);font-family:RedHatText,sans-serif;margin:0px;font-size:12px"><span>IM: <span>mikedep333</span></span></p><p style="color:rgb(0,0,0);font-family:RedHatText,sans-serif;font-size:12px;margin:0px"><span>GPG: 51745404</span></p><div style="color:rgb(0,0,0);font-family:RedHatText,sans-serif;font-size:medium;margin-top:12px"><table border="0"><tbody><tr><td width="100px"><a href="https://www.redhat.com/" target="_blank"><img src="https://marketing-outfit-prod-images.s3-us-west-2.amazonaws.com/f5445ae0c9ddafd5b2f1836854d7416a/Logo-RedHat-Email.png" width="90" height="auto"></a></td></tr></tbody></table></div></div></div>
_______________________________________________<br>
Pulp-dev mailing list<br>
<a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br>
</blockquote></div></div>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr"><div dir="ltr"><p style="color:rgb(0,0,0);font-family:RedHatText,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:capitalize"><span>Mike</span> <span>DePaulo</span><span style="text-transform:uppercase;color:rgb(170,170,170);margin:0px"></span></p><p style="color:rgb(0,0,0);font-family:RedHatText,sans-serif;font-size:12px;margin:0px 0px 4px;text-transform:capitalize">He / Him / His</p><p style="color:rgb(0,0,0);font-family:RedHatText,sans-serif;font-size:12px;margin:0px;text-transform:capitalize"><span>Service Reliability Engineer, Pulp</span></p><p style="color:rgb(0,0,0);font-family:RedHatText,sans-serif;margin:0px 0px 4px;font-size:12px"><a href="https://www.redhat.com/" style="color:rgb(0,136,206);margin:0px" target="_blank">Red Hat<span></span></a></p><div style="color:rgb(0,0,0);font-family:RedHatText,sans-serif;font-size:medium;margin-bottom:4px"></div><p style="color:rgb(0,0,0);font-family:RedHatText,sans-serif;margin:0px;font-size:12px"><span>IM: <span>mikedep333</span></span></p><p style="color:rgb(0,0,0);font-family:RedHatText,sans-serif;font-size:12px;margin:0px"><span>GPG: 51745404</span></p><div style="color:rgb(0,0,0);font-family:RedHatText,sans-serif;font-size:medium;margin-top:12px"><table border="0"><tbody><tr><td width="100px"><a href="https://www.redhat.com/" target="_blank"><img src="https://marketing-outfit-prod-images.s3-us-west-2.amazonaws.com/f5445ae0c9ddafd5b2f1836854d7416a/Logo-RedHat-Email.png" width="90" height="auto"></a></td></tr></tbody></table></div></div></div></div>
_______________________________________________<br>
Pulp-dev mailing list<br>
<a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br>
</blockquote></div>
</blockquote></div>
</blockquote></div>
_______________________________________________<br>
Pulp-dev mailing list<br>
<a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br>
</blockquote></div>
_______________________________________________<br>
Pulp-dev mailing list<br>
<a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br>
</blockquote></div></div>
_______________________________________________<br>
Pulp-dev mailing list<br>
<a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br>
</blockquote></div>