<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Oct 29, 2019 at 11:37 AM Brian Bouterse <<a href="mailto:bmbouter@redhat.com">bmbouter@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Oct 29, 2019 at 11:19 AM Brian Bouterse <<a href="mailto:bmbouter@redhat.com" target="_blank">bmbouter@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>A Distribution, e.g. <a href="https://docs.pulpproject.org/en/3.0/nightly/restapi.html#operation/distributions_file_file_read" target="_blank">FileDistribution</a> has a base_url (not base_path) which defaults to returning data with "relative" urls, e.g. "/pulp/content/foo/..." If you set the <a href="https://docs.pulpproject.org/en/3.0/nightly/installation/configuration.html#content-host" target="_blank">CONTENT_HOST</a> setting to "<a href="https://example.com:1234" target="_blank">https://example.com:1234</a>" then Pulp will return absolute URLs e.g. "<a href="https://example.com:1234/pulp/content/foo/.." target="_blank">https://example.com:1234/pulp/content/foo/..</a>."</div><div><br></div><div>Concerns with what we have currently:<br></div><div><br></div><div>1. plugins like pulp_docker require this CONTENT_HOST to be set, but others may not, so this setting could become a dividing line for plugins that want it set versus those that don't.<br></div><div><br></div><div>2. Clients are semantically unsure how to handle responses for one Pulp server versus another. This setting changes the client's responsibilities (relative vs absolute URL handling).<br></div><div><br></div><div>3. Relative urls are not as usable as absolute urls.</div><div><br></div><div><br></div><div># Option 1: Remove the setting and have plugins handle it</div><div>My concern with this option is that it's no easier to deal with plugin-by-plugin<br></div><div><br></div><div># Option 2: Keep the setting and make it a required (absolute URLs always)</div><div>Users would always have to be involved, but installer could get it right. RPM packages could not though since they don't know about multi-machine installs.</div></div></blockquote></div></div></blockquote><div>This is seeming more and more the only way to know if you want HTTP/HTTPS versus FQDN/localhost <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><br></div><div># Option 3: Option 2 + a default of FQDN</div><div>This would align with a default that serves Pulp publically to non-localhost environments.<br></div></div></blockquote></div></div></blockquote><div>I realized we would have to pick HTTP or HTTPS here. :( <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div></div><div><br></div><div># Option 4: Option 2 + a default of FQDN</div><div>This would align with a default that serves Pulp via localhost only</div></div></blockquote><div>correction, Option 4 is for a default of 'localhost'</div></div></div></blockquote><div>I realized we would have to pick HTTP or HTTPS here. :( <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><br></div><div># Any of the ^ options only consolidating <a href="https://docs.pulpproject.org/en/3.0/nightly/installation/configuration.html#content-path-prefix" target="_blank">CONTENT_PATH_PREFIX</a></div><div>Is this simpler?<br></div><div><br></div><div><br></div><div>What would best serve your plugin? What would best serve Pulp users?</div><div><br></div><div>Thanks!</div><div>Brian</div><div><br></div></div>
</blockquote></div></div>
</blockquote></div></div>