<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> </head> <body> <p>I much prefer this solution (A single RPM Repository type), and i think just using 'location_href' for a rpm uniquness within a repo version makes a lot of sense, overall +1.</p> <p>Justin<br> </p> <div class="moz-cite-prefix">On 3/23/20 4:27 PM, Daniel Alley wrote:<br> </div> <blockquote type="cite" cite="mid:CAK1D4mCVhE3qo-EixXd7BhhAN6f45e1d47+fn3rsJitTfA+hFg@mail.gmail.com"> <div dir="ltr"> <div>I think, as long as the metadata is correct, using just the location_href would be OK. It should contain all the other bits of information.<br> </div> </div> <br> <div class="gmail_quote"> <div dir="ltr" class="gmail_attr">On Mon, Mar 23, 2020 at 3:57 PM David Davis <<a href="mailto:daviddavis@redhat.com" moz-do-not-send="true">daviddavis@redhat.com</a>> wrote:<br> </div> <blockquote class="gmail_quote"> <div dir="ltr"> <div dir="ltr"> <div> <div dir="ltr"> <div dir="ltr"> <div dir="ltr"> <div dir="ltr"> <div dir="ltr"> <div>A couple questions below.</div> </div> </div> </div> </div> </div> </div> </div> <br> <div class="gmail_quote"> <div dir="ltr" class="gmail_attr">On Mon, Mar 23, 2020 at 3:47 PM Tatiana Tereshchenko <<a href="mailto:ttereshc@redhat.com" target="_blank" moz-do-not-send="true">ttereshc@redhat.com</a>> wrote:<br> </div> <blockquote class="gmail_quote"> <div dir="ltr">Clarification: <div>The proposal is to add the 'location_href' attribute to the repo_key_fields, uniqueness constraint within a repository version, so 2 packages with the same NEVRA but different location can be present in one repo.</div> </div> </blockquote> <div><br> </div> <div>Why have nevra+relative_path instead of just relative_path? ie would it be possible for two packages in a repo version to have the same relative_paths but different nevras?</div> <div> </div> <blockquote class="gmail_quote"> <div dir="ltr"> <div>RPM package is still uniquely identified in Pulp by NEVRA + checksum(aka pkgId) + checksum type.</div> </div> </blockquote> <div><br> </div> <div>What if a user has the same package in a repo at two different locations or the same package in two different repos at the different locations. Since relative_path is attached to the content unit, I think this would prevent this from happening? I wonder if uniqueness in Pulp should also have location_href/relative_path?</div> <div> </div> <blockquote class="gmail_quote"><br> <div class="gmail_quote"> <div dir="ltr" class="gmail_attr">On Mon, Mar 23, 2020 at 7:33 PM Grant Gainey <<a href="mailto:ggainey@redhat.com" target="_blank" moz-do-not-send="true">ggainey@redhat.com</a>> wrote:<br> </div> <blockquote class="gmail_quote"> <div dir="ltr"> <div dir="ltr">On Mon, Mar 23, 2020 at 2:01 PM Dennis Kliban <<a href="mailto:dkliban@redhat.com" target="_blank" moz-do-not-send="true">dkliban@redhat.com</a>> wrote:<br> </div> <div class="gmail_quote"> <blockquote class="gmail_quote"> <div dir="ltr"> <div>During last week's RPM team meeting, a concern was raised about using the same repository type for both Red Hat and SUSE repositories. Since that meeting I have only been able to identify a single difference between the two repositories. SUSE repos can contain the same package in two different locations in the same repository. Even though I just referred to this as a difference, I don't actually believe that to be true. All RPM repositories should be able to support this. <br> </div> </div> </blockquote> <div><br> </div> <div>If I'm reading the discussion w/the RPM folks correctly, this is 'odd but legal' for rpm-repositories. That means that, while SUSE may be the only current example, there's nothing to keep some other distro/thirdparty from doing the exact same thing, and we'd have to handle it.</div> <div> </div> <blockquote class="gmail_quote"> <div dir="ltr"> <div>I propose that we not add a separate repository type for SUSE and simply add the 'location' attribute of an RPM to it's uniqueness constraint. What do you all think? </div> </div> </blockquote> <div><br> </div> <div>Yeah, concur. It feels messy - but only because the problem-domain itself is messy :(</div> <div><br> </div> <div>G</div> <div><br> </div> <blockquote class="gmail_quote"> <div dir="ltr"> <div> </div> </div> _______________________________________________<br> Pulp-dev mailing list<br> <a href="mailto:Pulp-dev@redhat.com" target="_blank" moz-do-not-send="true">Pulp-dev@redhat.com</a><br> <a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank" moz-do-not-send="true">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br> </blockquote> </div> <br> <div><br> </div> -- <br> <div dir="ltr"> <div dir="ltr"> <div> <div dir="ltr"> <div>Grant Gainey</div> <div>Principal Software Engineer, Red Hat System Management Engineering</div> </div> </div> </div> </div> </div> _______________________________________________<br> Pulp-dev mailing list<br> <a href="mailto:Pulp-dev@redhat.com" target="_blank" moz-do-not-send="true">Pulp-dev@redhat.com</a><br> <a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank" moz-do-not-send="true">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br> </blockquote> </div> _______________________________________________<br> Pulp-dev mailing list<br> <a href="mailto:Pulp-dev@redhat.com" target="_blank" moz-do-not-send="true">Pulp-dev@redhat.com</a><br> <a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank" moz-do-not-send="true">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br> </blockquote> </div> </div> _______________________________________________<br> Pulp-dev mailing list<br> <a href="mailto:Pulp-dev@redhat.com" target="_blank" moz-do-not-send="true">Pulp-dev@redhat.com</a><br> <a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank" moz-do-not-send="true">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br> </blockquote> </div> <br> <fieldset class="mimeAttachmentHeader"></fieldset> <pre class="moz-quote-pre" wrap="">_______________________________________________ Pulp-dev mailing list <a class="moz-txt-link-abbreviated" href="mailto:Pulp-dev@redhat.com">Pulp-dev@redhat.com</a> <a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/pulp-dev">https://www.redhat.com/mailman/listinfo/pulp-dev</a> </pre> </blockquote> </body> </html>