<div dir="ltr"><div>see inline<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, May 11, 2020 at 10:14 PM Brian Bouterse <<a href="mailto:bmbouter@redhat.com">bmbouter@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Thank you for sharing this! Can a basic README be added showing a few things a user could try after installing it from source? I also put a few comments inline also.<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, May 11, 2020 at 1:53 PM David Davis <<a href="mailto:daviddavis@redhat.com" target="_blank">daviddavis@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Adding pulp-list to hopefully get user feedback on this.<br clear="all"><div><div dir="ltr"><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div><br></div><div>David</div></div></div></div></div></div></div></div><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, May 11, 2020 at 6:54 AM Matthias Dellweg <<a href="mailto:mdellweg@redhat.com" target="_blank">mdellweg@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>A first draft of the architecture that should eventually govern the pulp cli has been completed [0].</div><div>The feature set is naturally very limited, since we want to autotemplate most of this after getting good feedback about the architecture.</div><div><br></div><div>Questions we want to settle at this point are:<br></div><div> - Is the command structure comprehensive and useable?</div><div> 'pulp <plugin_name> <resource_class> [--type resource_type] <action> <...>'</div><div> 'pulp file repository list' === 'pulp file repository --type File list'<br></div></div></blockquote></div></blockquote><div>Does ^ mean the user would run `pulp file repository list`? If so then +1</div></div></div></blockquote><div>Yes, as "file" would be the default type in the file plugin.</div><div>I should have included more examples:</div><div> 'pulp status'</div><div> 'pulp file repository delete --name test_repository'<br></div><div> 'pulp deb publication --type verbatim create --version /pulp/api/v3/repositories/deb/deb/1234567890/versions/3'<br></div><div> 'pulp rpm content --type advisory list'</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div></div><div> - Is the implemented plugin autoloading useful?<br></div></div></blockquote></div></blockquote><div>It is useful, but why use importlib with naming conventions rather than each cli package declare a python entrypoint? I think entrypoints are a more common mechanism of discovery in Python.<br></div></div></div></blockquote><div>That was the one i found in the python docs (no extra external dependencies). I will have a go with the entrypoints.<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div></div><div> - Should we put the cli (plugin-)packages in the corresponding pulp plugin repos as subpackages?</div></div></blockquote></div></blockquote><div>I'm not entirely sure which is better. I *think* the decision should mainly come from how we want to test the CLI packages in CI. If we want to test them with every plugin change then we probably do want them in the same repo. This is similar reasoning to why we keep the bindings "with the plugin". What do you think?</div></div></div></blockquote><div>I am very glad You asked that question. Iirc, we decided to provide versions of those cli plugins compatible to the specific versions of the corresponding pulp plugins. Also they will have a similar strong dependence on the bindings. So i would even say we want to keep the versions in sync. Another reason to keep them in the same repository.<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><br></div><div>[0] <a href="https://github.com/mdellweg/pulp-cli" target="_blank">https://github.com/mdellweg/pulp-cli</a></div></div> _______________________________________________<br> Pulp-dev mailing list<br> <a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br> <a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br> </blockquote></div> _______________________________________________<br> Pulp-dev mailing list<br> <a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br> <a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br> </blockquote></div></div> </blockquote></div></div>