<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jul 28, 2020 at 12:17 PM David Davis <<a href="mailto:daviddavis@redhat.com">daviddavis@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr">On Tue, Jul 28, 2020 at 12:03 PM Justin Sherrill <<a href="mailto:jsherril@redhat.com" target="_blank">jsherril@redhat.com</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<p><br>
</p>
<div>On 7/28/20 11:44 AM, David Davis wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Today we discussed this at triage. We're leaning
towards changing the default from 20 to 10 as it seems like 10
only incurs an extra 30% penalty in time while seeming to fix
the problem[0].
<div><br>
</div>
<div>One question though is how we should treat existing data
because most Remotes at this point probably have a value of 20
for download_concurrency. We came up with two options that we
would like some feedback on.</div>
</div>
</blockquote>
<p>It seems kinda strange that the 'default' value is recorded in
the db on the remote at creation time. Any reason to just leave
it 'nil' and use the 'app default' ? This doesn't really help
with past values, but seems like a better model going forward.</p></div></blockquote><div><br></div><div>I think this maybe makes sense given that we'll potentially have to change it again if we find out that 10 doesn't work for some reason. Perhaps we could set a class constant on Remote that subclasses could override.</div></div></div></blockquote><div>One benefit of what we have now is that if you get a db dump, you can see all the data right there. One downside of what we have now is that we can't disambiguate a user intending to use the default from just receiving the default. Overall I value the simplicity of recording actual values in the db because it's simple, explicit, and consistent with how all other defaults work in Pulp.<br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div>
<blockquote type="cite">
<div dir="ltr">
<div><br>
</div>
<div><br>
</div>
<div># Option 1: Migrate 20 to 10</div>
<div><br>
</div>
<div>This would be a migration in pulpcore that would update
download_concurrency to 10 for all Remotes whose
download_concurrency is set to 10. Something like:</div>
<div><br>
</div>
<div>
Remote.objects.all().filter(download_concurrency=20).update(download_concurrency=10)</div>
<div><br>
</div>
</div>
</blockquote>
<p>My vote is for #1 because:</p>
<p>a) I imagine ~99% of people want the recommended default, so 99%
of people will either need to update this manually (if doing #2)
or face sync failures</p>
<p>b) i'd rather 99% of people not have to do anything than the 1%
that for some reason actually wanted 20 and weren't just going
with the 'recommended default' at that time. The number of people
in this case could very well be zero.<br>
</p>
<p><br>
</p>
<blockquote type="cite">
<div dir="ltr">
<div><br>
</div>
<div># Option 2: Documentation</div>
<div><br>
</div>
<div>This would be similar to the migration approach but instead
of modifying our users' data, we'd document how they could do
it themselves. So something like:</div>
<div><br>
</div>
<div> pulpcore-manager shell_plus -c
"Remote.objects.all().filter(download_concurrency=20).update(download_concurrency=10)</div>
<div><br>
</div>
<div><br>
</div>
<div>Any feedback is welcome.<br>
<div><br>
</div>
<div>[0] <a href="https://pulp.plan.io/issues/7186#note-2" target="_blank">https://pulp.plan.io/issues/7186#note-2</a><br>
<div>
<div dir="ltr">
<div dir="ltr">
<div>
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div><br>
</div>
<div>David</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<br>
</div>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Mon, Jul 27, 2020 at 2:57
PM Grant Gainey <<a href="mailto:ggainey@redhat.com" target="_blank">ggainey@redhat.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote">
<div dir="ltr">Hey folks,
<div><br>
</div>
<div>Looking into issue <a href="https://pulp.plan.io/issues/7212" target="_blank">7212</a> , over the weekend I did
some ad-hoc evaluations of sync-performance at various
concurrency settings. I wrote up my observations here:</div>
<div><br>
</div>
<div><a href="https://hackmd.io/@ggainey/pulp3_sync_concurrency" target="_blank">https://hackmd.io/@ggainey/pulp3_sync_concurrency</a><br>
<div><br>
</div>
<div>Just thought folk might be interested.</div>
<div><br>
</div>
<div>G</div>
-- <br>
<div dir="ltr">
<div dir="ltr">
<div>
<div dir="ltr">
<div>Grant Gainey</div>
<div>Principal Software Engineer, Red Hat System
Management Engineering</div>
<div><br>
</div>
<div><br>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
_______________________________________________<br>
Pulp-dev mailing list<br>
<a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br>
</blockquote>
</div>
<br>
<fieldset></fieldset>
<pre>_______________________________________________
Pulp-dev mailing list
<a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a>
<a href="https://www.redhat.com/mailman/listinfo/pulp-dev" target="_blank">https://www.redhat.com/mailman/listinfo/pulp-dev</a>
</pre>
</blockquote>
</div>
_______________________________________________<br>
Pulp-dev mailing list<br>
<a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br>
</blockquote></div></div>
_______________________________________________<br>
Pulp-dev mailing list<br>
<a href="mailto:Pulp-dev@redhat.com" target="_blank">Pulp-dev@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/pulp-dev" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/pulp-dev</a><br>
</blockquote></div></div>