<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Accidentally replied privately last time.<div><br></div><div>This is good practice for another reason as well: We tend to end up implementing cross-collection functionality and usually have more than one id floating around. It's a lot easier to keep them straight if they're all prefixed.</div><div><br><div apple-content-edited="true">
<span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div>Jason L Connor</div><div>linear on freenode #pulp</div><div><a href="http://pulpproject.org/">http://pulpproject.org/</a></div><div>RHCE: 805010912355231</div><div>GPG Fingerprint: 2048R/CC4ED7C1</div><div><br></div></span><br class="Apple-interchange-newline">
</div>
<br><div><div>On Jul 31, 2012, at 10:55 PM, Jason Connor <<a href="mailto:jconnor@redhat.com">jconnor@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=us-ascii"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">+1<div><br><div><div apple-content-edited="true">
<span class="Apple-style-span" style="border-collapse: separate; font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; border-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div>Jason L Connor</div><div>linear on freenode #pulp</div><div><a href="http://pulpproject.org/">http://pulpproject.org/</a></div><div>RHCE: 805010912355231</div><div>GPG Fingerprint: 2048R/CC4ED7C1</div><div><br></div></span><br class="Apple-interchange-newline">
</div>
<br><div><div>On Jul 31, 2012, at 2:04 PM, James Slagle <<a href="mailto:jslagle@redhat.com">jslagle@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Looking around, I see usage of id as a variable name. id is actually a python<br>built-in. I don't know of any specific issues (debuggers perhaps) overriding<br>it might cause, but in general, I think it's a good idea not to override<br>built-ins with local variables names.<br><br>I've cleaned up a few areas that I'm working in. But, it might be a good idea<br>to do a mass cleanup as well.<br><br>I would also argue id doesn't make a great variable name anyway :). It would<br>probably be more clear to use repo_id, consumer_id, etc.<br><br>--<br>-- James Slagle<br>--<br><br>_______________________________________________<br>Pulp-list mailing list<br><a href="mailto:Pulp-list@redhat.com">Pulp-list@redhat.com</a><br><a href="https://www.redhat.com/mailman/listinfo/pulp-list">https://www.redhat.com/mailman/listinfo/pulp-list</a><br></blockquote></div><br></div></div></div></blockquote></div><br></div></body></html>