<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">On 3/26/21 4:16 PM, Grant Gainey wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CACudCSRY+Svykrqdbu5cZayV=UWXuNDSmfLmqK1VEm_3uuCtPw@mail.gmail.com">
<div dir="ltr">
<div dir="ltr">On Fri, Mar 26, 2021 at 4:01 PM Justin Sherrill
<<a href="mailto:jsherril@redhat.com"
moz-do-not-send="true">jsherril@redhat.com</a>> wrote:<br>
</div>
<div class="gmail_quote">
<blockquote class="gmail_quote">Hello!<br>
<br>
I had some questions for the timeout options here: <br>
<a
href="https://docs.pulpproject.org/pulp_rpm/restapi.html#operation/remotes_rpm_rpm_create"
rel="noreferrer" target="_blank" moz-do-not-send="true">https://docs.pulpproject.org/pulp_rpm/restapi.html#operation/remotes_rpm_rpm_create</a>\<br>
<br>
1. Do the default values come from <br>
<a
href="https://docs.aiohttp.org/en/stable/client_reference.html"
rel="noreferrer" target="_blank" moz-do-not-send="true">https://docs.aiohttp.org/en/stable/client_reference.html</a>
or are they <br>
set in pulp (and if so what are they?)<br>
</blockquote>
<div><br>
</div>
<div>Pulp defers to aiohttp - see <a
href="https://github.com/pulp/pulpcore/pull/1026#discussion_r533710092"
moz-do-not-send="true">https://github.com/pulp/pulpcore/pull/1026#discussion_r533710092</a> for
the discussion on that. </div>
<div><br>
</div>
<blockquote class="gmail_quote">
2. Two of those aiohttp settings look deprecated
(read_timeout & <br>
conn_timeout), but are exposed in pulp, is that intentional
?<br>
</blockquote>
<div><br>
</div>
<div>It is intentional, in that they were in the original
issue, and I didn't notice they were deprecated when writing
the code, alas :(</div>
</div>
</div>
</blockquote>
<p>Apologies, i was looking at the wrong class (ClientSession),
these options map straight to the ClientTimeout class and are NOT
deprecated. Thanks for the clarification!</p>
<p>Justin<br>
</p>
<p><br>
</p>
<blockquote type="cite"
cite="mid:CACudCSRY+Svykrqdbu5cZayV=UWXuNDSmfLmqK1VEm_3uuCtPw@mail.gmail.com">
<div dir="ltr">
<div class="gmail_quote">
<div><br>
</div>
<div>G</div>
</div>
-- <br>
<div dir="ltr" class="gmail_signature">
<div dir="ltr">
<div>
<div dir="ltr">
<div>Grant Gainey</div>
<div>Principal Software Engineer, Red Hat System
Management Engineering</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</body>
</html>