[redhat-lspp] Re: [RFC][PATCH 1/2] MLSXFRM: Granular IPSec associations for MLS environments

[James Morris]

On Wed, 5 Jul 2006, Venkat Yekkirala wrote:

> --- linux-2.6.17.i686.vanilla/include/net/flow.h	2006-06-17 20:49:35.000000000 -0500
> +++ linux-2.6.17.i686/include/net/flow.h	2006-07-05 14:38:51.000000000 -0500
> @@ -78,6 +78,7 @@ struct flowi {
>  #define fl_icmp_type	uli_u.icmpt.type
>  #define fl_icmp_code	uli_u.icmpt.code
>  #define fl_ipsec_spi	uli_u.spi
> +	__u32           sid;	/* used by xfrm; see flow_sid.txt */
>  } __attribute__((__aligned__(BITS_PER_LONG/8)));

Please avoid the use of 'sid' anywhere in core kernel code, as it has a 
specific meaning there which will confuse other developers.

Use 'secid' instead, which we've been starting to use with new code.

(At some point all of them will be cleaned up, but not now).



- James
-- 
James Morris
<jmorris at redhat.com>