<div dir="ltr">Thanks all,<div><br></div><div>I have updated the code based on your advice.</div><div><a href="https://github.com/tanaka-takayoshi/sos/blob/mssql/sos/plugins/mssql.py">https://github.com/tanaka-takayoshi/sos/blob/mssql/sos/plugins/mssql.py</a><br><div class="gmail_extra"><br></div><div class="gmail_extra">After I complete some tests, I'll make a pull request to GitHub.</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, May 24, 2018 at 9:43 PM, Bryn M. Reeves <span dir="ltr"><<a href="mailto:bmr@redhat.com" target="_blank">bmr@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span>On Thu, May 24, 2018 at 01:03:16PM +0200, Pavel Moravec wrote:<br>
> Creating PR directly is IMHO fine, you can get better feedback there<br>
> pinpointing to particular lines etc. - a code review is better to be done<br>
> in github PR than via mail.<br>
<br>
</span>We allow either ;)<br>
<br>
Personally, I'm a bit sad that everything has shifted to GitHub,<br>
because I think that email provides a more natural format to have<br>
a conversation: no vanishing diffs, no "outdated comments".. just<br>
good ol' fashioned email.<br>
<span> <br>
> - instead of pure URL with mssql.conf format, it is (also) worth explaining<br>
> what the further code performs<br>
<br>
</span>I'm not sure the URL is actually all that useful here; it's an INI<br>
file from which we want to obtain two keys.<br>
<br>
If anything just a brief comment explaining those two keys would<br>
seem sufficient.<br>
<br>
Regards,<br>
Bryn.<br>
<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail-m_-760851809159965833gmail_signature"><div dir="ltr"><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase"><span>TAKAYOSHI</span> <span>TANAKA</span></p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><span>SOFTWARE MAINTENANCE ENGINEER</span><span style="color:rgb(204,204,204)">, <span style="color:rgb(170,170,170);margin:0px">RHCA, MICROSOFT MVP</span></span></p><p style="font-family:overpass,sans-serif;margin:0px;font-size:10px;color:rgb(153,153,153)"><a href="https://www.redhat.com/" style="color:rgb(0,136,206);margin:0px" target="_blank">Red Hat <span>K.K.</span></a></p><span style="font-family:overpass,sans-serif;font-size:10px;margin:0px;color:rgb(153,153,153)"><p style="margin:0px">8F, Ebisu Neonato, 4-1-18 Ebisu</p></span><span style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium"></span><span style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium"><p style="font-size:10px;margin:0px;color:rgb(153,153,153)">Shibuya-ku Tokyo, 150-0013, Japan</p></span><span style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium"></span><p style="font-family:overpass,sans-serif;margin:0px 0px 6px;font-size:10px;color:rgb(153,153,153)"><span style="margin:0px;padding:0px"><a href="mailto:tatanaka@redhat.com" style="color:rgb(0,136,206);margin:0px" target="_blank">tatanaka@redhat.com</a>   </span> <span>M: <a href="tel:+81-80-4193-5143" style="color:rgb(0,136,206);font-size:11px;margin:0px" target="_blank">+81-80-4193-5143</a>    </span> <span>IM: <span>tatanaka</span></span></p><table border="0" style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium"><tbody><tr><td width="100px"><a href="https://red.ht/sig" target="_blank"><img src="https://www.redhat.com/files/brand/email/sig-redhat.png" width="90" height="auto"></a></td></tr></tbody></table></div></div>
</div></div></div>