<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:"Consolas","serif";
color:black;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body bgcolor="white" lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">Just an FYI (for anyone that cares) –<o:p></o:p></p>
<p class="MsoNormal"> “<i>There's only one other GMT-0500 timezone choice available (Indiana), where they don't observe DST”</i> – actually, yes they do. They (the state of Indiana) adopted DST in 2005 and implemented it in 2006.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Alan <span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext"> spacewalk-list-bounces@redhat.com [mailto:spacewalk-list-bounces@redhat.com]
<b>On Behalf Of </b>Duncan Mac-Vicar P.<br>
<b>Sent:</b> Friday, March 28, 2014 12:17 PM<br>
<b>To:</b> Ron Helzer<br>
<b>Cc:</b> spacewalk-list@redhat.com; spacewalk-devel<br>
<b>Subject:</b> [BULK] Re: [Spacewalk-list] Incorrect timezone in new 2.1 date / time picker.<br>
<b>Importance:</b> Low<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On 28/03/14 17:05, Ron Helzer wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal">There's only one other GMT-0500 timezone choice available (Indiana), where they don't observe DST... That, in conjunction with the fact that there were no DST issues pre-2.1, would suggest to me that the GMT-0500 (Eastern) setting should
account for EDT/EST change. <o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Are you suggesting I'm supposed to change the preference twice a year to manually account for DST?<o:p></o:p></p>
</div>
</blockquote>
<p class="MsoNormal"><br>
No, I am just trying to understand where the issue can come from, as I don't think anything changed at all.<br>
<br>
In 2.0 the date picker fragment got the timezone from the DatePicker bean (picker.calendar.timeZone)<br>
<a href="https://github.com/spacewalkproject/spacewalk/blob/SPACEWALK-2.0/java/code/webapp/WEB-INF/pages/common/fragments/date-picker.jsp">https://github.com/spacewalkproject/spacewalk/blob/SPACEWALK-2.0/java/code/webapp/WEB-INF/pages/common/fragments/date-picker.jsp</a>
(line 60)<br>
<br>
In 2.1, the JSP tag gets the timezone from the DatePicker bean in the same way<br>
<a href="https://github.com/spacewalkproject/spacewalk/blob/SPACEWALK-2.1/java/code/src/com/redhat/rhn/frontend/taglibs/DateTimePickerTag.java">https://github.com/spacewalkproject/spacewalk/blob/SPACEWALK-2.1/java/code/src/com/redhat/rhn/frontend/taglibs/DateTimePickerTag.java</a>
(line 225)<br>
<br>
Then the time passed to the server on submit does not carry the timezone, so it is always relative to the one it was shown to you.<br>
(I am not saying there is not a problem, but I can't see how it would be new if there is).<br>
<br>
CCing -devel in case anyone sees something I am missing.<br>
<br>
<o:p></o:p></p>
<pre>-- <o:p></o:p></pre>
<pre>Duncan Mac-Vicar P. - <a href="http://www.suse.com/">http://www.suse.com/</a><o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) <o:p></o:p></pre>
<pre>Maxfeldstraße 5, 90409 Nürnberg, Germany<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
</div>
</body>
</html>