[edk2-codereview][PATCH v1 0/1] Update pip-requirements to align with version 0.13.x

mdkinney via TianoCore Webhook webhook at tianocore.org
Wed Mar 25 17:59:50 UTC 2020


> > ####
> > # PR: https://github.com/mdkinney/edk2-codereview/pull/19
> > # Base SHA: 83b393e1e9162ffbd5fcd543f7475f5858c12054
> > # Submitter: [spbrogan]
> > # Maintainer: Michael D Kinney <michael.d.kinney at intel.com> [mdkinney]
> > # Maintainer: Sumana Venur <sumana.venur at intel.com> [svenur]
> > ####
> > 
> > This is me trying to break things for Mike.  A new PR for the same branch as a closed PR with the same commits.  Good luck.  :) 
> > -- 
> > diff --git a/pip-requirements.txt b/pip-requirements.txt
> > index 6a41a95..978268f 100644
> > --- a/pip-requirements.txt
> > +++ b/pip-requirements.txt
> > @@ -9,8 +9,10 @@
> >  # https://pypi.org/project/pip/
> >  # https://pip.pypa.io/en/stable/user_guide/#requirements-files
> >  # https://pip.pypa.io/en/stable/reference/pip_install/#requirements-file-format
> > -#
> > +# https://www.python.org/dev/peps/pep-0440/#version-specifiers
--------------------
> On 2020-03-25 01:07:52 @spbrogan wrote:
> "Add single comment"  line comment.  Thanks for adding this great link
--------------------
On 2020-03-25 17:54:22 @mdkinney wrote:
The link looks good to me (with edits)
--------------------
> >  ##
> >  
> >  edk2-pytool-library==0.10.*
> > -edk2-pytool-extensions==0.12.*
> > +
> > +# ~= means 0.13.3 or greater within 0.13.*
> > +edk2-pytool-extensions~=0.13.3





More information about the tianocore-code-review-poc mailing list