[edk2-codereview][PATCH v1 1/5] Add new file 1.txt

niruiyu via TianoCore Webhook tianocoregitactionbot at gmail.com
Mon May 11 17:17:20 UTC 2020


> > > > > From: Michael D Kinney <michael.d.kinney at intel.com>
> > > > > 
> > > > > Another line
> > > > > 
> > > > > 3rd line
> > > > > 
> > > > > Signed-off-by: Michael D Kinney <michael.d.kinney at intel.com>
> > > > > ---
> > > > > ####
> > > > > # PR(open): https://github.com/tianocore/edk2-codereview/pull/1
> > > > > # Base SHA: eabce7bc5ac4ce4e94c0c30eb3752cab76266943
> > > > > # Submitter: [mdkinney]
> > > > > # Commit: https://github.com/tianocore/edk2-codereview/commit/441a008424d031949547b4d6dfa851ef895c2d4d
> > > > > # Maintainer: Laszlo Ersek <lersek at redhat.com> [lersek]
> > > > > # Maintainer: Andrew Fish <afish at apple.com> [ajfish]
> > > > > # Maintainer: Michael D Kinney <michael.d.kinney at intel.com> [mdkinney]
> > > > > # Maintainer: Leif Lindholm <leif at nuviainc.com> [leiflindholm]
> > > > > ####
> > > > > 
--------------------
> > > > On 2020-05-11 17:20:47 @mdkinney wrote:
> > > > [CodeReview] Review-request @ajfish
> > > > [CodeReview] Review-request @mdkinney
> > > > [CodeReview] Review-request @lersek
> > > > [CodeReview] Review-request @leiflindholm
> > > > @niruiyu reacted with +1
--------------------
> > > On 2020-05-11 22:33:51 @lersek wrote:
> > > Reviewed-by: Laszlo Ersek <lersek at redhat.com>
--------------------
> > On 2020-05-12 01:36:47 @niruiyu wrote:
> > Why put Hello and World in separate lines instead of "Hello world!"? 
> > Anyway, Reviewed-by: Ray Ni <ray.ni at intel.com>
> > 
> > Edit this commit message and let's see what happens.
> > @niruiyu reacted with confused
--------------------
> On 2020-05-12 01:39:45 @niruiyu wrote:
> > [CodeReview] Review-request @ajfish
> > [CodeReview] Review-request @mdkinney
> > [CodeReview] Review-request @lersek
> > [CodeReview] Review-request @leiflindholm
> 
> The mail achieves already use quote-reply stile. Let's see what I 
> manually use quote-reply.
--------------------
On 2020-05-12 01:41:14 @niruiyu wrote:
My 3rd comment.
--------------------




More information about the tianocore-code-review-poc mailing list