[edk2-codereview][PATCH v1 0/5] Add a small patch series to test webhook connection

niruiyu via TianoCore Webhook tianocoregitactionbot at gmail.com
Wed May 13 12:24:20 UTC 2020


> > > > > > ####
> > > > > > # PR(open): https://github.com/tianocore/edk2-codereview/pull/1
> > > > > > # Base SHA: eabce7bc5ac4ce4e94c0c30eb3752cab76266943
> > > > > > # Submitter: [mdkinney]
> > > > > > # Maintainer: Laszlo Ersek <lersek at redhat.com> [lersek]
> > > > > > # Maintainer: Andrew Fish <afish at apple.com> [ajfish]
> > > > > > # Maintainer: Michael D Kinney <michael.d.kinney at intel.com> [mdkinney]
> > > > > > # Maintainer: Leif Lindholm <leif at nuviainc.com> [leiflindholm]
> > > > > > ####
> > > > > > 
> > > > > > Add a small patch series with 5 commits that adds 5 files to the root 
> > > > > > of the repo.
> > > > > > 
> > > > > > This patch series is not intended to be merged.  It will be closed and
> > > > > > abandoned later.
> > > > > > 
> > > > > > Signed-off-by: Michael D Kinney <michael.d.kinney at intel.com>
--------------------
> > > > > On 2020-05-11 18:19:45 @bcran wrote:
> > > > > ```Reviewed-by: Rebecca Cran <rebecca at bsdio.com>```
> > > > > 
> > > > > Is there a limit on the size of patches that will be sent to the 
> > > > > mailing list?
--------------------
> > > > On 2020-05-11 18:54:19 @mdkinney wrote:
> > > > I have tested a large number of patches in a patch series to make sure
> > > > we do not have the groups.io limitations.
> > > > 
> > > > I have not tried a large single patch yet to see what the size limit 
> > > > is.  This would be a good unit test.
--------------------
> > > On 2020-05-11 22:52:41 @lersek wrote:
> > > Usability question:
> > > 
> > > assume I open the following link in a new browser window: 
> > > `https://github.com/tianocore/edk2-codereview/commit/441a008424d031949547b4d6dfa851ef895c2d4d#comments`
> > > and leave a comment there. Further assume that I've closed all other 
> > > browser windows and tabs.
> > > 
> > > How do I get back from that view to the containing pull request, in my
> > > browser?
> > > 
> > > Thanks.
--------------------
> > On 2020-05-11 22:55:10 @lersek wrote:
> > Another question:
> > 
> > I've provided feedback on all five patches, one by one. The banner at 
> > the top of this page still says my review is being requested. How do I
> > make that go away? Thanks.
--------------------
> On 2020-05-11 22:56:09 @lersek started a review with state CHANGES_REQUESTED:
> ... I guess I can say "please see my per-patch comments".
> (and because some of those comments request a re-spin, I'll have to 
> select the "request changes" radio button here)
--------------------
On 2020-05-13 12:24:18 @niruiyu wrote:
All
--------------------




More information about the tianocore-code-review-poc mailing list