From tianocoregitactionbot at gmail.com Tue Jun 15 03:55:09 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Mon, 14 Jun 2021 20:55:09 -0700 Subject: [edk2-codereview][PATCH v4 0/1] Add new files 1.txt and 2.txt In-Reply-To: Message-ID: > > > > > > > > > > > #### > > > > > > > > > > > # PR(open): https://github.com/mdkinney/edk2-codereview/pull/30 > > > > > > > > > > > # Base SHA: 83b393e1e9162ffbd5fcd543f7475f5858c12054 > > > > > > > > > > > # Submitter: [mdkinney] > > > > > > > > > > > # Maintainer: Michael D Kinney [mdkinney] > > > > > > > > > > > # Maintainer: Sumana Venur [svenur] > > > > > > > > > > > #### > > > > > > > > > > > > > > > > > > > > > > Another line (edited) > > > > > > > > > > > > > > > > > > > > > > 3rd line > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Michael D Kinney -------------------- > > > > > > > > > > On 2020-05-04 21:59:59 @mdkinney wrote: > > > > > > > > > > Add a PR level comment -------------------- > > > > > > > > > On 2020-05-04 22:00:14 @mdkinney wrote: > > > > > > > > > Close PR -------------------- > > > > > > > > On 2020-05-04 22:00:21 @mdkinney wrote: > > > > > > > > Reopen PR -------------------- > > > > > > > On 2020-05-15 18:24:54 @svenur started a review with state APPROVED: > > > > > > > Changes looking good -------------------- > > > > > > On 2021-03-30 22:33:07 @mdkinney wrote: > > > > > > Add a comment -------------------- > > > > > On 2021-03-30 22:36:42 @mdkinney wrote: > > > > > Add another comment -------------------- > > > > On 2021-03-30 22:40:32 @mdkinney wrote: > > > > And add another comment -------------------- > > > On 2021-03-30 22:41:20 @mdkinney wrote: > > > And yet another comment -------------------- > > On 2021-03-30 22:46:57 @mdkinney wrote: > > Try again -------------------- > On 2021-06-15 03:49:53 @mdkinney wrote: > Add a new comment -------------------- On 2021-06-15 03:55:06 @mdkinney wrote: Add another comment -------------------- From tianocoregitactionbot at gmail.com Thu Jun 17 20:16:46 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Thu, 17 Jun 2021 13:16:46 -0700 Subject: [edk2-codereview][PATCH v1 0/1] edk2-codereview: Add file Message-ID: #### # PR(open): https://github.com/tianocore/edk2-codereview/pull/5 # Base SHA: 9e6bb647e389e604cf2b35afa3d9d3178b190963 # Submitter: [mdkinney] # Maintainer: Andrew Fish [ajfish] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Laszlo Ersek [lersek] # Maintainer: Leif Lindholm [leiflindholm] #### Signed-off-by: Michael D Kinney Michael D Kinney (1): edk2-codereview: Add file AddFile.txt | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 AddFile.txt -- From tianocoregitactionbot at gmail.com Thu Jun 17 20:16:10 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Thu, 17 Jun 2021 13:16:10 -0700 Subject: [edk2-codereview][PATCH v1 1/1] edk2-codereview: Add file In-Reply-To: Message-ID: From: Michael D Kinney Signed-off-by: Michael D Kinney --- #### # PR(open): https://github.com/tianocore/edk2-codereview/pull/5 # Base SHA: 9e6bb647e389e604cf2b35afa3d9d3178b190963 # Submitter: [mdkinney] # Commit: https://github.com/tianocore/edk2-codereview/commit/944015b0a671cedf412d6b384be608ec9c2e5d0a # Maintainer: Andrew Fish [ajfish] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Laszlo Ersek [lersek] # Maintainer: Leif Lindholm [leiflindholm] #### AddFile.txt | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 AddFile.txt diff --git a/AddFile.txt b/AddFile.txt new file mode 100644 index 0000000..e132343 --- /dev/null +++ b/AddFile.txt @@ -0,0 +1,3 @@ +Test file: + +Add line #1 -- 2.25.1 From tianocoregitactionbot at gmail.com Thu Jun 17 20:21:14 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Thu, 17 Jun 2021 13:21:14 -0700 Subject: [edk2-codereview][PATCH v1 0/1] edk2-codereview: Add file In-Reply-To: Message-ID: #### # PR(closed): https://github.com/tianocore/edk2-codereview/pull/5 # Base SHA: 9e6bb647e389e604cf2b35afa3d9d3178b190963 # Submitter: [mdkinney] # Maintainer: Andrew Fish [ajfish] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Laszlo Ersek [lersek] # Maintainer: Leif Lindholm [leiflindholm] #### Signed-off-by: Michael D Kinney Michael D Kinney (1): edk2-codereview: Add file AddFile.txt | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 AddFile.txt -- From tianocoregitactionbot at gmail.com Thu Jun 17 20:24:52 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Thu, 17 Jun 2021 13:24:52 -0700 Subject: [edk2-codereview][PATCH v1 1/1] edk2-codereview: Add another file In-Reply-To: Message-ID: From: Michael D Kinney See if Mergify will attempt auto rebase. Signed-off-by: Michael D Kinney --- #### # PR(open): https://github.com/tianocore/edk2-codereview/pull/6 # Base SHA: 0726025e6d2696388f35da8cad8b639cf2d273c4 # Submitter: [mdkinney] # Commit: https://github.com/tianocore/edk2-codereview/commit/b3006d808eb731821154b582aac4536c9f5f0484 # Maintainer: Andrew Fish [ajfish] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Laszlo Ersek [lersek] # Maintainer: Leif Lindholm [leiflindholm] #### AddAnotherFile.txt | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 AddAnotherFile.txt diff --git a/AddAnotherFile.txt b/AddAnotherFile.txt new file mode 100644 index 0000000..8255477 --- /dev/null +++ b/AddAnotherFile.txt @@ -0,0 +1,3 @@ +Another Test file: + +Add line #1 -- 2.25.1 From tianocoregitactionbot at gmail.com Thu Jun 17 20:25:30 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Thu, 17 Jun 2021 13:25:30 -0700 Subject: [edk2-codereview][PATCH v1 0/1] edk2-codereview: Add another file Message-ID: #### # PR(open): https://github.com/tianocore/edk2-codereview/pull/6 # Base SHA: 0726025e6d2696388f35da8cad8b639cf2d273c4 # Submitter: [mdkinney] # Maintainer: Andrew Fish [ajfish] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Laszlo Ersek [lersek] # Maintainer: Leif Lindholm [leiflindholm] #### See if Mergify will attempt auto rebase. Signed-off-by: Michael D Kinney Michael D Kinney (1): edk2-codereview: Add another file AddAnotherFile.txt | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 AddAnotherFile.txt -- From tianocoregitactionbot at gmail.com Thu Jun 17 20:16:10 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Thu, 17 Jun 2021 13:16:10 -0700 Subject: [edk2-codereview][PATCH v1 2/2] edk2-codereview: Add file In-Reply-To: Message-ID: From: Michael D Kinney Signed-off-by: Michael D Kinney --- #### # PR(open): https://github.com/tianocore/edk2-codereview/pull/6 # Base SHA: 0726025e6d2696388f35da8cad8b639cf2d273c4 # Submitter: [mdkinney] # Commit: https://github.com/tianocore/edk2-codereview/commit/0b25ec29efdf64d3dfa5fad3d6d8499a4b75d9d7 # Maintainer: Andrew Fish [ajfish] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Laszlo Ersek [lersek] # Maintainer: Leif Lindholm [leiflindholm] #### AddFile.txt | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 AddFile.txt diff --git a/AddFile.txt b/AddFile.txt new file mode 100644 index 0000000..e132343 --- /dev/null +++ b/AddFile.txt @@ -0,0 +1,3 @@ +Test file: + +Add line #1 -- 2.25.1 From tianocoregitactionbot at gmail.com Thu Jun 17 20:49:33 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Thu, 17 Jun 2021 13:49:33 -0700 Subject: [edk2-codereview][PATCH v1 0/1] .mergify: Remove status names and depend on GitHub rules Message-ID: #### # PR(open): https://github.com/tianocore/edk2-codereview/pull/7 # Base SHA: 0726025e6d2696388f35da8cad8b639cf2d273c4 # Submitter: [mdkinney] # Reviewer : Bret Barkelew [corthon] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Liming Gao [lgao4] # Reviewer : Sean Brogan [spbrogan] #### Signed-off-by: Michael D Kinney Michael D Kinney (1): .mergify: Remove status names and depend on GitHub rules .mergify/config.yml | 6 ------ 1 file changed, 6 deletions(-) -- From tianocoregitactionbot at gmail.com Thu Jun 17 20:48:54 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Thu, 17 Jun 2021 13:48:54 -0700 Subject: [edk2-codereview][PATCH v1 1/1] .mergify: Remove status names and depend on GitHub rules In-Reply-To: Message-ID: From: Michael D Kinney Signed-off-by: Michael D Kinney --- #### # PR(open): https://github.com/tianocore/edk2-codereview/pull/7 # Base SHA: 0726025e6d2696388f35da8cad8b639cf2d273c4 # Submitter: [mdkinney] # Commit: https://github.com/tianocore/edk2-codereview/commit/a6942c191e4f69c0cfce8f240ad35fedfa5467e0 # Reviewer : Bret Barkelew [corthon] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Liming Gao [lgao4] # Reviewer : Sean Brogan [spbrogan] #### .mergify/config.yml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.mergify/config.yml b/.mergify/config.yml index 99f10ed..4fb783a 100644 --- a/.mergify/config.yml +++ b/.mergify/config.yml @@ -30,9 +30,6 @@ queue_rules: - base~=(^master|^stable/) - label=push - author=@tianocore/edk-ii-maintainers - - status-success=tianocore.PatchCheck - - status-success=Ubuntu GCC5 PR - - status-success=Windows VS2019 PR pull_request_rules: - name: Automatically merge a PR when all required checks pass and 'push' label is present @@ -40,9 +37,6 @@ pull_request_rules: - base~=(^master|^stable/) - label=push - author=@tianocore/edk-ii-maintainers - - status-success=tianocore.PatchCheck - - status-success=Ubuntu GCC5 PR - - status-success=Windows VS2019 PR actions: queue: method: rebase -- 2.25.1 From tianocoregitactionbot at gmail.com Thu Jun 17 20:50:43 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Thu, 17 Jun 2021 13:50:43 -0700 Subject: [edk2-codereview][PATCH v2 0/1] .mergify: Remove status names and depend on GitHub rules Message-ID: #### # PR(open): https://github.com/tianocore/edk2-codereview/pull/7 # Base SHA: 0726025e6d2696388f35da8cad8b639cf2d273c4 # Submitter: [mdkinney] # Reviewer : Bret Barkelew [corthon] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Liming Gao [lgao4] # Reviewer : Sean Brogan [spbrogan] #### Signed-off-by: Michael D Kinney Michael D Kinney (1): .mergify: Remove status names and depend on GitHub rules .mergify/config.yml | 6 ------ 1 file changed, 6 deletions(-) -- From tianocoregitactionbot at gmail.com Thu Jun 17 20:48:54 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Thu, 17 Jun 2021 13:48:54 -0700 Subject: [edk2-codereview][PATCH v2 1/1] .mergify: Remove status names and depend on GitHub rules In-Reply-To: Message-ID: From: Michael D Kinney Signed-off-by: Michael D Kinney --- #### # PR(open): https://github.com/tianocore/edk2-codereview/pull/7 # Base SHA: 0726025e6d2696388f35da8cad8b639cf2d273c4 # Submitter: [mdkinney] # Commit: https://github.com/tianocore/edk2-codereview/commit/1e2af6134e7007094f22a01ae762e93beef3a233 # Reviewer : Bret Barkelew [corthon] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Liming Gao [lgao4] # Reviewer : Sean Brogan [spbrogan] #### .mergify/config.yml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.mergify/config.yml b/.mergify/config.yml index 99f10ed..4fb783a 100644 --- a/.mergify/config.yml +++ b/.mergify/config.yml @@ -30,9 +30,6 @@ queue_rules: - base~=(^master|^stable/) - label=push - author=@tianocore/edk-ii-maintainers - - status-success=tianocore.PatchCheck - - status-success=Ubuntu GCC5 PR - - status-success=Windows VS2019 PR pull_request_rules: - name: Automatically merge a PR when all required checks pass and 'push' label is present @@ -40,9 +37,6 @@ pull_request_rules: - base~=(^master|^stable/) - label=push - author=@tianocore/edk-ii-maintainers - - status-success=tianocore.PatchCheck - - status-success=Ubuntu GCC5 PR - - status-success=Windows VS2019 PR actions: queue: method: rebase -- 2.25.1 From tianocoregitactionbot at gmail.com Thu Jun 17 20:54:04 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Thu, 17 Jun 2021 13:54:04 -0700 Subject: [edk2-codereview][PATCH v2 0/1] .mergify: Remove status names and depend on GitHub rules In-Reply-To: Message-ID: #### # PR(closed): https://github.com/tianocore/edk2-codereview/pull/7 # Base SHA: 0726025e6d2696388f35da8cad8b639cf2d273c4 # Submitter: [mdkinney] # Reviewer : Bret Barkelew [corthon] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Liming Gao [lgao4] # Reviewer : Sean Brogan [spbrogan] #### Signed-off-by: Michael D Kinney Michael D Kinney (1): .mergify: Remove status names and depend on GitHub rules .mergify/config.yml | 6 ------ 1 file changed, 6 deletions(-) -- From tianocoregitactionbot at gmail.com Thu Jun 17 20:55:55 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Thu, 17 Jun 2021 13:55:55 -0700 Subject: [edk2-codereview][PATCH v1 0/1] edk2-codereview: Add another file In-Reply-To: Message-ID: > #### > # PR(open): https://github.com/tianocore/edk2-codereview/pull/6 > # Base SHA: 0726025e6d2696388f35da8cad8b639cf2d273c4 > # Submitter: [mdkinney] > # Maintainer: Andrew Fish [ajfish] > # Maintainer: Michael D Kinney [mdkinney] > # Maintainer: Laszlo Ersek [lersek] > # Maintainer: Leif Lindholm [leiflindholm] > #### > > See if Mergify will attempt auto rebase. > > Signed-off-by: Michael D Kinney -------------------- On 2021-06-17 20:55:52 @mdkinney wrote: @Mergifyio refresh @mergify[bot] reacted with +1 -------------------- From tianocoregitactionbot at gmail.com Thu Jun 17 20:56:27 2021 From: tianocoregitactionbot at gmail.com (mergify[bot] via TianoCore Webhook) Date: Thu, 17 Jun 2021 13:56:27 -0700 Subject: [edk2-codereview][PATCH v1 0/1] edk2-codereview: Add another file In-Reply-To: Message-ID: > > #### > > # PR(open): https://github.com/tianocore/edk2-codereview/pull/6 > > # Base SHA: 0726025e6d2696388f35da8cad8b639cf2d273c4 > > # Submitter: [mdkinney] > > # Maintainer: Andrew Fish [ajfish] > > # Maintainer: Michael D Kinney [mdkinney] > > # Maintainer: Laszlo Ersek [lersek] > > # Maintainer: Leif Lindholm [leiflindholm] > > #### > > > > See if Mergify will attempt auto rebase. > > > > Signed-off-by: Michael D Kinney -------------------- > On 2021-06-17 20:55:52 @mdkinney wrote: > @Mergifyio refresh > @mergify[bot] reacted with +1 -------------------- On 2021-06-17 20:56:25 @mergify[bot] wrote: **Command `refresh`: success** > **Pull request refreshed** > -------------------- From tianocoregitactionbot at gmail.com Thu Jun 17 20:48:54 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Thu, 17 Jun 2021 13:48:54 -0700 Subject: [edk2-codereview][PATCH v1 3/3] .mergify: Remove status names and depend on GitHub rules In-Reply-To: Message-ID: From: Michael D Kinney Signed-off-by: Michael D Kinney --- #### # PR(open): https://github.com/tianocore/edk2-codereview/pull/6 # Base SHA: 692677b167dd83102a5e7730a8fb3f7448f15075 # Submitter: [mdkinney] # Commit: https://github.com/tianocore/edk2-codereview/commit/5063747af52cd94623da5cfaad0ebbb1645a8246 # Reviewer : Bret Barkelew [corthon] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Liming Gao [lgao4] # Reviewer : Sean Brogan [spbrogan] #### .mergify/config.yml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.mergify/config.yml b/.mergify/config.yml index 99f10ed..4fb783a 100644 --- a/.mergify/config.yml +++ b/.mergify/config.yml @@ -30,9 +30,6 @@ queue_rules: - base~=(^master|^stable/) - label=push - author=@tianocore/edk-ii-maintainers - - status-success=tianocore.PatchCheck - - status-success=Ubuntu GCC5 PR - - status-success=Windows VS2019 PR pull_request_rules: - name: Automatically merge a PR when all required checks pass and 'push' label is present @@ -40,9 +37,6 @@ pull_request_rules: - base~=(^master|^stable/) - label=push - author=@tianocore/edk-ii-maintainers - - status-success=tianocore.PatchCheck - - status-success=Ubuntu GCC5 PR - - status-success=Windows VS2019 PR actions: queue: method: rebase -- 2.25.1 From tianocoregitactionbot at gmail.com Thu Jun 17 20:59:05 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Thu, 17 Jun 2021 13:59:05 -0700 Subject: [edk2-codereview][PATCH v1 0/1] edk2-codereview: Add another file In-Reply-To: Message-ID: #### # PR(closed): https://github.com/tianocore/edk2-codereview/pull/6 # Base SHA: 692677b167dd83102a5e7730a8fb3f7448f15075 # Submitter: [mdkinney] # Maintainer: Liming Gao [lgao4] # Maintainer: Michael D Kinney [mdkinney] # Reviewer : Sean Brogan [spbrogan] # Maintainer: Leif Lindholm [leiflindholm] # Maintainer: Andrew Fish [ajfish] # Maintainer: Laszlo Ersek [lersek] # Reviewer : Bret Barkelew [corthon] #### See if Mergify will attempt auto rebase. Signed-off-by: Michael D Kinney Michael D Kinney (1): edk2-codereview: Add another file AddAnotherFile.txt | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 AddAnotherFile.txt -- From tianocoregitactionbot at gmail.com Thu Jun 17 21:17:10 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Thu, 17 Jun 2021 14:17:10 -0700 Subject: [edk2-codereview][PATCH v1 1/1] edk2-codereview: Add file 0004 In-Reply-To: Message-ID: From: Michael D Kinney Signed-off-by: Michael D Kinney --- #### # PR(open): https://github.com/tianocore/edk2-codereview/pull/8 # Base SHA: 995c5bde03da0e0557fc7a39bd9ebe533c4559b7 # Submitter: [mdkinney] # Commit: https://github.com/tianocore/edk2-codereview/commit/84c52e821f9fddd24e863162fbf077ad6ddcde69 # Maintainer: Andrew Fish [ajfish] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Laszlo Ersek [lersek] # Maintainer: Leif Lindholm [leiflindholm] #### AddFile0004.txt | 1 + 1 file changed, 1 insertion(+) create mode 100644 AddFile0004.txt diff --git a/AddFile0004.txt b/AddFile0004.txt new file mode 100644 index 0000000..25a2020 --- /dev/null +++ b/AddFile0004.txt @@ -0,0 +1 @@ +Add file 0004 -- 2.25.1 From tianocoregitactionbot at gmail.com Thu Jun 17 21:17:49 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Thu, 17 Jun 2021 14:17:49 -0700 Subject: [edk2-codereview][PATCH v1 0/1] edk2-codereview: Add file 0004 Message-ID: #### # PR(open): https://github.com/tianocore/edk2-codereview/pull/8 # Base SHA: 995c5bde03da0e0557fc7a39bd9ebe533c4559b7 # Submitter: [mdkinney] # Maintainer: Andrew Fish [ajfish] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Laszlo Ersek [lersek] # Maintainer: Leif Lindholm [leiflindholm] #### Signed-off-by: Michael D Kinney Michael D Kinney (1): edk2-codereview: Add file 0004 AddFile0004.txt | 1 + 1 file changed, 1 insertion(+) create mode 100644 AddFile0004.txt -- From tianocoregitactionbot at gmail.com Thu Jun 17 21:18:07 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Thu, 17 Jun 2021 14:18:07 -0700 Subject: [edk2-codereview][PATCH v1 0/1] edk2-codereview: Add File 0003 Message-ID: #### # PR(open): https://github.com/tianocore/edk2-codereview/pull/9 # Base SHA: 995c5bde03da0e0557fc7a39bd9ebe533c4559b7 # Submitter: [mdkinney] # Maintainer: Andrew Fish [ajfish] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Laszlo Ersek [lersek] # Maintainer: Leif Lindholm [leiflindholm] #### Signed-off-by: Michael D Kinney Michael D Kinney (1): edk2-codereview: Add File 0003 AddFile0003.txt | 1 + 1 file changed, 1 insertion(+) create mode 100644 AddFile0003.txt -- From tianocoregitactionbot at gmail.com Thu Jun 17 21:16:20 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Thu, 17 Jun 2021 14:16:20 -0700 Subject: [edk2-codereview][PATCH v1 1/1] edk2-codereview: Add File 0003 In-Reply-To: Message-ID: From: Michael D Kinney Signed-off-by: Michael D Kinney --- #### # PR(open): https://github.com/tianocore/edk2-codereview/pull/9 # Base SHA: 995c5bde03da0e0557fc7a39bd9ebe533c4559b7 # Submitter: [mdkinney] # Commit: https://github.com/tianocore/edk2-codereview/commit/fc468f00890f74519b620f7f677e1a3617893e33 # Maintainer: Andrew Fish [ajfish] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Laszlo Ersek [lersek] # Maintainer: Leif Lindholm [leiflindholm] #### AddFile0003.txt | 1 + 1 file changed, 1 insertion(+) create mode 100644 AddFile0003.txt diff --git a/AddFile0003.txt b/AddFile0003.txt new file mode 100644 index 0000000..664c083 --- /dev/null +++ b/AddFile0003.txt @@ -0,0 +1 @@ +Add file for Test0003 -- 2.25.1 From tianocoregitactionbot at gmail.com Thu Jun 17 21:20:15 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Thu, 17 Jun 2021 14:20:15 -0700 Subject: [edk2-codereview][PATCH v1 0/1] edk2-codereview: Add file 0004 In-Reply-To: Message-ID: #### # PR(closed): https://github.com/tianocore/edk2-codereview/pull/8 # Base SHA: 995c5bde03da0e0557fc7a39bd9ebe533c4559b7 # Submitter: [mdkinney] # Maintainer: Andrew Fish [ajfish] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Laszlo Ersek [lersek] # Maintainer: Leif Lindholm [leiflindholm] #### Signed-off-by: Michael D Kinney Michael D Kinney (1): edk2-codereview: Add file 0004 AddFile0004.txt | 1 + 1 file changed, 1 insertion(+) create mode 100644 AddFile0004.txt -- From tianocoregitactionbot at gmail.com Thu Jun 17 21:17:10 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Thu, 17 Jun 2021 14:17:10 -0700 Subject: [edk2-codereview][PATCH v1 2/2] edk2-codereview: Add file 0004 In-Reply-To: Message-ID: From: Michael D Kinney Signed-off-by: Michael D Kinney --- #### # PR(open): https://github.com/tianocore/edk2-codereview/pull/9 # Base SHA: 93b8be31ebb2c9a7bac3ca9e7b39728a861f0aa5 # Submitter: [mdkinney] # Commit: https://github.com/tianocore/edk2-codereview/commit/1ffed4a650caf96a6fcf20af6ec05b3e5fe596b7 # Maintainer: Andrew Fish [ajfish] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Laszlo Ersek [lersek] # Maintainer: Leif Lindholm [leiflindholm] #### AddFile0004.txt | 1 + 1 file changed, 1 insertion(+) create mode 100644 AddFile0004.txt diff --git a/AddFile0004.txt b/AddFile0004.txt new file mode 100644 index 0000000..25a2020 --- /dev/null +++ b/AddFile0004.txt @@ -0,0 +1 @@ +Add file 0004 -- 2.25.1 From tianocoregitactionbot at gmail.com Thu Jun 17 21:25:25 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Thu, 17 Jun 2021 14:25:25 -0700 Subject: [edk2-codereview][PATCH v1 0/1] edk2-codereview: Add File 0003 In-Reply-To: Message-ID: #### # PR(closed): https://github.com/tianocore/edk2-codereview/pull/9 # Base SHA: 93b8be31ebb2c9a7bac3ca9e7b39728a861f0aa5 # Submitter: [mdkinney] # Maintainer: Andrew Fish [ajfish] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Laszlo Ersek [lersek] # Maintainer: Leif Lindholm [leiflindholm] #### Signed-off-by: Michael D Kinney Michael D Kinney (1): edk2-codereview: Add File 0003 AddFile0003.txt | 1 + 1 file changed, 1 insertion(+) create mode 100644 AddFile0003.txt -- From tianocoregitactionbot at gmail.com Fri Jun 18 03:16:32 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Thu, 17 Jun 2021 20:16:32 -0700 Subject: [edk2-codereview][PATCH v1 0/1] BaseTools/Scripts: No PatchCheck error for Mergify merge commits Message-ID: #### # PR(open): https://github.com/tianocore/edk2-codereview/pull/10 # Base SHA: abff0d705a133f7e6fd367631ff71aee86893a40 # Submitter: [mdkinney] # Maintainer: Bob Feng [BobCF] # Maintainer: Liming Gao [lgao4] # Reviewer : Yuwei Chen #### Do not generate an error if a merge commit from Mergify is detected in the patch set. Signed-off-by: Michael D Kinney Michael D Kinney (1): BaseTools/Scripts: No PatchCheck error for Mergify merge commits BaseTools/Scripts/PatchCheck.py | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) -- From tianocoregitactionbot at gmail.com Fri Jun 18 03:14:44 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Thu, 17 Jun 2021 20:14:44 -0700 Subject: [edk2-codereview][PATCH v1 1/1] BaseTools/Scripts: No PatchCheck error for Mergify merge commits In-Reply-To: Message-ID: From: Michael D Kinney Do not generate an error if a merge commit from Mergify is detected in the patch set. Signed-off-by: Michael D Kinney --- #### # PR(open): https://github.com/tianocore/edk2-codereview/pull/10 # Base SHA: abff0d705a133f7e6fd367631ff71aee86893a40 # Submitter: [mdkinney] # Commit: https://github.com/tianocore/edk2-codereview/commit/7779b6206c6dbd0b595e5141465e57a550bc0545 # Maintainer: Bob Feng [BobCF] # Maintainer: Liming Gao [lgao4] # Reviewer : Yuwei Chen #### BaseTools/Scripts/PatchCheck.py | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py index 80754e7..a8a1294 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -1,7 +1,7 @@ ## @file # Check a patch for various format issues # -# Copyright (c) 2015 - 2020, Intel Corporation. All rights reserved.
+# Copyright (c) 2015 - 2021, Intel Corporation. All rights reserved.
# Copyright (C) 2020, Red Hat, Inc.
# Copyright (c) 2020, ARM Ltd. All rights reserved.
# @@ -89,20 +89,26 @@ class EmailAddressCheck: class CommitMessageCheck: """Checks the contents of a git commit message.""" - def __init__(self, subject, message): + def __init__(self, subject, message, author_email): self.ok = True if subject is None and message is None: self.error('Commit message is missing!') return + MergifyMerge = False + if "mergify[bot]@users.noreply.github.com" in author_email: + if "Merge branch" in subject: + MergifyMerge = True + self.subject = subject self.msg = message print (subject) self.check_contributed_under() - self.check_signed_off_by() + if not MergifyMerge: + self.check_signed_off_by() self.check_misc_signatures() self.check_overall_format() self.report_message_result() @@ -522,7 +528,7 @@ class CheckOnePatch: email_check = EmailAddressCheck(self.author_email, 'Author') email_ok = email_check.ok - msg_check = CommitMessageCheck(self.commit_subject, self.commit_msg) + msg_check = CommitMessageCheck(self.commit_subject, self.commit_msg, self.author_email) msg_ok = msg_check.ok diff_ok = True -- 2.25.1 From tianocoregitactionbot at gmail.com Fri Jun 18 03:25:17 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Thu, 17 Jun 2021 20:25:17 -0700 Subject: [edk2-codereview][PATCH v1 0/1] BaseTools/Scripts: No PatchCheck error for Mergify merge commits In-Reply-To: Message-ID: #### # PR(closed): https://github.com/tianocore/edk2-codereview/pull/10 # Base SHA: abff0d705a133f7e6fd367631ff71aee86893a40 # Submitter: [mdkinney] # Maintainer: Bob Feng [BobCF] # Maintainer: Liming Gao [lgao4] # Reviewer : Yuwei Chen #### Do not generate an error if a merge commit from Mergify is detected in the patch set. Signed-off-by: Michael D Kinney Michael D Kinney (1): BaseTools/Scripts: No PatchCheck error for Mergify merge commits BaseTools/Scripts/PatchCheck.py | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) -- From tianocoregitactionbot at gmail.com Fri Jun 18 03:33:29 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Thu, 17 Jun 2021 20:33:29 -0700 Subject: [edk2-codereview][PATCH v1 0/1] Revert "edk2-codereview: Add file 0004" Message-ID: #### # PR(open): https://github.com/tianocore/edk2-codereview/pull/11 # Base SHA: 1b264739387ae940b42d70b5cd25b7c68ed21318 # Submitter: [mdkinney] # Maintainer: Andrew Fish [ajfish] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Laszlo Ersek [lersek] # Maintainer: Leif Lindholm [leiflindholm] #### This reverts commit 93b8be31ebb2c9a7bac3ca9e7b39728a861f0aa5. Signed-off-by: Michael D Kinney Michael D Kinney (1): Revert "edk2-codereview: Add file 0004" AddFile0004.txt | 1 - 1 file changed, 1 deletion(-) delete mode 100644 AddFile0004.txt -- From tianocoregitactionbot at gmail.com Fri Jun 18 03:29:05 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Thu, 17 Jun 2021 20:29:05 -0700 Subject: [edk2-codereview][PATCH v1 1/1] Revert "edk2-codereview: Add file 0004" In-Reply-To: Message-ID: From: Michael D Kinney This reverts commit 93b8be31ebb2c9a7bac3ca9e7b39728a861f0aa5. Signed-off-by: Michael D Kinney --- #### # PR(open): https://github.com/tianocore/edk2-codereview/pull/11 # Base SHA: 1b264739387ae940b42d70b5cd25b7c68ed21318 # Submitter: [mdkinney] # Commit: https://github.com/tianocore/edk2-codereview/commit/2729a017f7f965a0fb89221c2960e606c6ee9bfd # Maintainer: Andrew Fish [ajfish] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Laszlo Ersek [lersek] # Maintainer: Leif Lindholm [leiflindholm] #### AddFile0004.txt | 1 - 1 file changed, 1 deletion(-) delete mode 100644 AddFile0004.txt diff --git a/AddFile0004.txt b/AddFile0004.txt deleted file mode 100644 index 25a2020..0000000 --- a/AddFile0004.txt +++ /dev/null @@ -1 +0,0 @@ -Add file 0004 -- 2.25.1 From tianocoregitactionbot at gmail.com Fri Jun 18 03:33:53 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Thu, 17 Jun 2021 20:33:53 -0700 Subject: [edk2-codereview][PATCH v1 0/1] Revert "edk2-codereview: Add File 0003" Message-ID: #### # PR(open): https://github.com/tianocore/edk2-codereview/pull/12 # Base SHA: 1b264739387ae940b42d70b5cd25b7c68ed21318 # Submitter: [mdkinney] # Maintainer: Andrew Fish [ajfish] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Laszlo Ersek [lersek] # Maintainer: Leif Lindholm [leiflindholm] #### This reverts commit abff0d705a133f7e6fd367631ff71aee86893a40. Signed-off-by: Michael D Kinney Michael D Kinney (1): Revert "edk2-codereview: Add File 0003" AddFile0003.txt | 1 - 1 file changed, 1 deletion(-) delete mode 100644 AddFile0003.txt -- From tianocoregitactionbot at gmail.com Fri Jun 18 03:30:26 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Thu, 17 Jun 2021 20:30:26 -0700 Subject: [edk2-codereview][PATCH v1 1/1] Revert "edk2-codereview: Add File 0003" In-Reply-To: Message-ID: From: Michael D Kinney This reverts commit abff0d705a133f7e6fd367631ff71aee86893a40. Signed-off-by: Michael D Kinney --- #### # PR(open): https://github.com/tianocore/edk2-codereview/pull/12 # Base SHA: 1b264739387ae940b42d70b5cd25b7c68ed21318 # Submitter: [mdkinney] # Commit: https://github.com/tianocore/edk2-codereview/commit/49b355dddb6f3058899a07d25dbfe6236343e08e # Maintainer: Andrew Fish [ajfish] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Laszlo Ersek [lersek] # Maintainer: Leif Lindholm [leiflindholm] #### AddFile0003.txt | 1 - 1 file changed, 1 deletion(-) delete mode 100644 AddFile0003.txt diff --git a/AddFile0003.txt b/AddFile0003.txt deleted file mode 100644 index 664c083..0000000 --- a/AddFile0003.txt +++ /dev/null @@ -1 +0,0 @@ -Add file for Test0003 -- 2.25.1 From tianocoregitactionbot at gmail.com Fri Jun 18 03:14:44 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Thu, 17 Jun 2021 20:14:44 -0700 Subject: [edk2-codereview][PATCH v1 2/2] BaseTools/Scripts: No PatchCheck error for Mergify merge commits In-Reply-To: Message-ID: From: Michael D Kinney Do not generate an error if a merge commit from Mergify is detected in the patch set. Signed-off-by: Michael D Kinney --- #### # PR(open): https://github.com/tianocore/edk2-codereview/pull/11 # Base SHA: 1b264739387ae940b42d70b5cd25b7c68ed21318 # Submitter: [mdkinney] # Commit: https://github.com/tianocore/edk2-codereview/commit/4e245a82cf8a916362ee383e8a01026e328494e2 # Maintainer: Bob Feng [BobCF] # Maintainer: Liming Gao [lgao4] # Reviewer : Yuwei Chen #### BaseTools/Scripts/PatchCheck.py | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py index 80754e7..a8a1294 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -1,7 +1,7 @@ ## @file # Check a patch for various format issues # -# Copyright (c) 2015 - 2020, Intel Corporation. All rights reserved.
+# Copyright (c) 2015 - 2021, Intel Corporation. All rights reserved.
# Copyright (C) 2020, Red Hat, Inc.
# Copyright (c) 2020, ARM Ltd. All rights reserved.
# @@ -89,20 +89,26 @@ class EmailAddressCheck: class CommitMessageCheck: """Checks the contents of a git commit message.""" - def __init__(self, subject, message): + def __init__(self, subject, message, author_email): self.ok = True if subject is None and message is None: self.error('Commit message is missing!') return + MergifyMerge = False + if "mergify[bot]@users.noreply.github.com" in author_email: + if "Merge branch" in subject: + MergifyMerge = True + self.subject = subject self.msg = message print (subject) self.check_contributed_under() - self.check_signed_off_by() + if not MergifyMerge: + self.check_signed_off_by() self.check_misc_signatures() self.check_overall_format() self.report_message_result() @@ -522,7 +528,7 @@ class CheckOnePatch: email_check = EmailAddressCheck(self.author_email, 'Author') email_ok = email_check.ok - msg_check = CommitMessageCheck(self.commit_subject, self.commit_msg) + msg_check = CommitMessageCheck(self.commit_subject, self.commit_msg, self.author_email) msg_ok = msg_check.ok diff_ok = True -- 2.25.1 From tianocoregitactionbot at gmail.com Fri Jun 18 03:38:58 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Thu, 17 Jun 2021 20:38:58 -0700 Subject: [edk2-codereview][PATCH v1 0/1] Revert "edk2-codereview: Add file 0004" In-Reply-To: Message-ID: #### # PR(closed): https://github.com/tianocore/edk2-codereview/pull/11 # Base SHA: 1b264739387ae940b42d70b5cd25b7c68ed21318 # Submitter: [mdkinney] # Maintainer: Liming Gao [lgao4] # Reviewer : Yuwei Chen # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Leif Lindholm [leiflindholm] # Maintainer: Andrew Fish [ajfish] # Maintainer: Laszlo Ersek [lersek] # Maintainer: Bob Feng [BobCF] #### This reverts commit 93b8be31ebb2c9a7bac3ca9e7b39728a861f0aa5. Signed-off-by: Michael D Kinney Michael D Kinney (1): Revert "edk2-codereview: Add file 0004" AddFile0004.txt | 1 - 1 file changed, 1 deletion(-) delete mode 100644 AddFile0004.txt -- From tianocoregitactionbot at gmail.com Fri Jun 18 03:14:44 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Thu, 17 Jun 2021 20:14:44 -0700 Subject: [edk2-codereview][PATCH v1 2/2] BaseTools/Scripts: No PatchCheck error for Mergify merge commits In-Reply-To: Message-ID: From: Michael D Kinney Do not generate an error if a merge commit from Mergify is detected in the patch set. Signed-off-by: Michael D Kinney --- #### # PR(open): https://github.com/tianocore/edk2-codereview/pull/12 # Base SHA: 95730c309b44f3147d9b8cb1551bb2786d064ca6 # Submitter: [mdkinney] # Commit: https://github.com/tianocore/edk2-codereview/commit/efb6869fef91036084888027c08369707b2351c8 # Maintainer: Liming Gao [lgao4] # Reviewer : Yuwei Chen # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Leif Lindholm [leiflindholm] # Maintainer: Andrew Fish [ajfish] # Maintainer: Laszlo Ersek [lersek] # Maintainer: Bob Feng [BobCF] #### BaseTools/Scripts/PatchCheck.py | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py index 80754e7..a8a1294 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -1,7 +1,7 @@ ## @file # Check a patch for various format issues # -# Copyright (c) 2015 - 2020, Intel Corporation. All rights reserved.
+# Copyright (c) 2015 - 2021, Intel Corporation. All rights reserved.
# Copyright (C) 2020, Red Hat, Inc.
# Copyright (c) 2020, ARM Ltd. All rights reserved.
# @@ -89,20 +89,26 @@ class EmailAddressCheck: class CommitMessageCheck: """Checks the contents of a git commit message.""" - def __init__(self, subject, message): + def __init__(self, subject, message, author_email): self.ok = True if subject is None and message is None: self.error('Commit message is missing!') return + MergifyMerge = False + if "mergify[bot]@users.noreply.github.com" in author_email: + if "Merge branch" in subject: + MergifyMerge = True + self.subject = subject self.msg = message print (subject) self.check_contributed_under() - self.check_signed_off_by() + if not MergifyMerge: + self.check_signed_off_by() self.check_misc_signatures() self.check_overall_format() self.report_message_result() @@ -522,7 +528,7 @@ class CheckOnePatch: email_check = EmailAddressCheck(self.author_email, 'Author') email_ok = email_check.ok - msg_check = CommitMessageCheck(self.commit_subject, self.commit_msg) + msg_check = CommitMessageCheck(self.commit_subject, self.commit_msg, self.author_email) msg_ok = msg_check.ok diff_ok = True -- 2.25.1 >From 95730c309b44f3147d9b8cb1551bb2786d064ca6 Mon Sep 17 00:00:00 2001 From: mdkinney via TianoCore Webhook Date: Thu, 17 Jun 2021 20:29:05 -0700 Subject: [edk2-codereview][PATCH v1 2/2] Revert "edk2-codereview: Add file 0004" In-Reply-To: Message-ID: To: From: Michael D Kinney This reverts commit 93b8be31ebb2c9a7bac3ca9e7b39728a861f0aa5. Signed-off-by: Michael D Kinney --- AddFile0004.txt | 1 - 1 file changed, 1 deletion(-) delete mode 100644 AddFile0004.txt diff --git a/AddFile0004.txt b/AddFile0004.txt deleted file mode 100644 index 25a2020..0000000 --- a/AddFile0004.txt +++ /dev/null @@ -1 +0,0 @@ -Add file 0004 -- 2.25.1 From tianocoregitactionbot at gmail.com Fri Jun 18 03:42:23 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Thu, 17 Jun 2021 20:42:23 -0700 Subject: [edk2-codereview][PATCH v1 0/1] Revert "edk2-codereview: Add File 0003" In-Reply-To: Message-ID: #### # PR(closed): https://github.com/tianocore/edk2-codereview/pull/12 # Base SHA: 95730c309b44f3147d9b8cb1551bb2786d064ca6 # Submitter: [mdkinney] # Maintainer: Liming Gao [lgao4] # Reviewer : Yuwei Chen # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Leif Lindholm [leiflindholm] # Maintainer: Andrew Fish [ajfish] # Maintainer: Laszlo Ersek [lersek] # Maintainer: Bob Feng [BobCF] #### This reverts commit abff0d705a133f7e6fd367631ff71aee86893a40. Signed-off-by: Michael D Kinney Michael D Kinney (1): Revert "edk2-codereview: Add File 0003" AddFile0003.txt | 1 - 1 file changed, 1 deletion(-) delete mode 100644 AddFile0003.txt -- From tianocoregitactionbot at gmail.com Tue Jun 22 22:50:59 2021 From: tianocoregitactionbot at gmail.com (edk2codereviewtest via TianoCore Webhook) Date: Tue, 22 Jun 2021 15:50:59 -0700 Subject: [edk2-codereview][PATCH v2 0/1] Revert "edk2-codereview: Add another file" In-Reply-To: Message-ID: #### # PR(closed): https://github.com/tianocore/edk2-codereview/pull/15 # Base SHA: 7fa5662e1fafba6aea4dea4b2b5fadae25d2d798 # Submitter: [edk2codereviewtest] # Maintainer: Leif Lindholm [leiflindholm] # Maintainer: Laszlo Ersek [lersek] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Andrew Fish [ajfish] #### This reverts commit 995c5bde03da0e0557fc7a39bd9ebe533c4559b7. EDK II Code Review Test (1): Revert "edk2-codereview: Add another file" AddAnotherFile.txt | 3 --- 1 file changed, 3 deletions(-) delete mode 100644 AddAnotherFile.txt -- From tianocoregitactionbot at gmail.com Tue Jun 22 18:22:00 2021 From: tianocoregitactionbot at gmail.com (edk2codereviewtest via TianoCore Webhook) Date: Tue, 22 Jun 2021 11:22:00 -0700 Subject: [edk2-codereview][PATCH v2 1/1] Revert "edk2-codereview: Add another file" In-Reply-To: Message-ID: From: EDK II Code Review Test This reverts commit 995c5bde03da0e0557fc7a39bd9ebe533c4559b7. Signed-off-by: EDK II Code Review Test --- #### # PR(open): https://github.com/tianocore/edk2-codereview/pull/15 # Base SHA: 7fa5662e1fafba6aea4dea4b2b5fadae25d2d798 # Submitter: [edk2codereviewtest] # Commit: https://github.com/tianocore/edk2-codereview/commit/76e588456db9c046f6fc912599e8250abea5e70c # Maintainer: Leif Lindholm [leiflindholm] # Maintainer: Laszlo Ersek [lersek] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Andrew Fish [ajfish] #### AddAnotherFile.txt | 3 --- 1 file changed, 3 deletions(-) delete mode 100644 AddAnotherFile.txt diff --git a/AddAnotherFile.txt b/AddAnotherFile.txt deleted file mode 100644 index 8255477..0000000 --- a/AddAnotherFile.txt +++ /dev/null @@ -1,3 +0,0 @@ -Another Test file: - -Add line #1 -- 2.25.1 From tianocoregitactionbot at gmail.com Tue Jun 22 22:49:11 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Tue, 22 Jun 2021 15:49:11 -0700 Subject: [edk2-codereview][PATCH v2 0/1] Revert "edk2-codereview: Add another file" In-Reply-To: Message-ID: > > #### > > # PR(open): https://github.com/tianocore/edk2-codereview/pull/15 > > # Base SHA: 7fa5662e1fafba6aea4dea4b2b5fadae25d2d798 > > # Submitter: [edk2codereviewtest] > > # Maintainer: Leif Lindholm [leiflindholm] > > # Maintainer: Laszlo Ersek [lersek] > > # Maintainer: Michael D Kinney [mdkinney] > > # Maintainer: Andrew Fish [ajfish] > > #### > > > > This reverts commit 995c5bde03da0e0557fc7a39bd9ebe533c4559b7. -------------------- > On 2021-06-22 22:39:32 @mdkinney wrote: > Need to add Signed-off-by to commit message -------------------- On 2021-06-22 22:49:08 @mdkinney wrote: Reviewed-by: Michael D Kinney -------------------- From tianocoregitactionbot at gmail.com Tue Jun 22 22:50:25 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Tue, 22 Jun 2021 15:50:25 -0700 Subject: [edk2-codereview][PATCH v2 0/1] Revert "edk2-codereview: Add another file" In-Reply-To: Message-ID: > > > #### > > > # PR(open): https://github.com/tianocore/edk2-codereview/pull/15 > > > # Base SHA: 7fa5662e1fafba6aea4dea4b2b5fadae25d2d798 > > > # Submitter: [edk2codereviewtest] > > > # Maintainer: Leif Lindholm [leiflindholm] > > > # Maintainer: Laszlo Ersek [lersek] > > > # Maintainer: Michael D Kinney [mdkinney] > > > # Maintainer: Andrew Fish [ajfish] > > > #### > > > > > > This reverts commit 995c5bde03da0e0557fc7a39bd9ebe533c4559b7. -------------------- > > On 2021-06-22 22:39:32 @mdkinney wrote: > > Need to add Signed-off-by to commit message -------------------- > On 2021-06-22 22:49:08 @mdkinney wrote: > Reviewed-by: Michael D Kinney -------------------- On 2021-06-22 22:50:21 @mdkinney started a review with state APPROVED: -------------------- From tianocoregitactionbot at gmail.com Tue Jun 22 23:00:32 2021 From: tianocoregitactionbot at gmail.com (edk2codereviewtest via TianoCore Webhook) Date: Tue, 22 Jun 2021 16:00:32 -0700 Subject: [edk2-codereview][PATCH v1 0/1] edk2-codereview: Add Test0010.txt Message-ID: #### # PR(open): https://github.com/tianocore/edk2-codereview/pull/16 # Base SHA: 16826b354211e0de7b6f76b8594ebf515ad36b73 # Submitter: [edk2codereviewtest] # Maintainer: Leif Lindholm [leiflindholm] # Maintainer: Laszlo Ersek [lersek] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Andrew Fish [ajfish] #### Signed-off-by: EDK II Code Review Test EDK II Code Review Test (1): edk2-codereview: Add Test0010.txt Test0010.txt | 1 + 1 file changed, 1 insertion(+) create mode 100644 Test0010.txt -- From tianocoregitactionbot at gmail.com Tue Jun 22 22:59:00 2021 From: tianocoregitactionbot at gmail.com (edk2codereviewtest via TianoCore Webhook) Date: Tue, 22 Jun 2021 15:59:00 -0700 Subject: [edk2-codereview][PATCH v1 1/1] edk2-codereview: Add Test0010.txt In-Reply-To: Message-ID: From: EDK II Code Review Test Signed-off-by: EDK II Code Review Test --- #### # PR(open): https://github.com/tianocore/edk2-codereview/pull/16 # Base SHA: 16826b354211e0de7b6f76b8594ebf515ad36b73 # Submitter: [edk2codereviewtest] # Commit: https://github.com/tianocore/edk2-codereview/commit/5be2578af8200aa7c47799d3eb72f818a7d26faa # Maintainer: Leif Lindholm [leiflindholm] # Maintainer: Laszlo Ersek [lersek] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Andrew Fish [ajfish] #### Test0010.txt | 1 + 1 file changed, 1 insertion(+) create mode 100644 Test0010.txt diff --git a/Test0010.txt b/Test0010.txt new file mode 100644 index 0000000..56fbf54 --- /dev/null +++ b/Test0010.txt @@ -0,0 +1 @@ +Add test file -- 2.25.1 From tianocoregitactionbot at gmail.com Tue Jun 22 23:00:06 2021 From: tianocoregitactionbot at gmail.com (edk2codereviewtest via TianoCore Webhook) Date: Tue, 22 Jun 2021 16:00:06 -0700 Subject: [edk2-codereview][PATCH v1 1/1] edk2-codereview: Add file Test0011.txt In-Reply-To: Message-ID: From: EDK II Code Review Test Signed-off-by: EDK II Code Review Test --- #### # PR(open): https://github.com/tianocore/edk2-codereview/pull/17 # Base SHA: 16826b354211e0de7b6f76b8594ebf515ad36b73 # Submitter: [edk2codereviewtest] # Commit: https://github.com/tianocore/edk2-codereview/commit/c121f513e1508abebc9b4de05d101ac45933e5f7 # Maintainer: Leif Lindholm [leiflindholm] # Maintainer: Laszlo Ersek [lersek] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Andrew Fish [ajfish] #### Test0011.txt | 1 + 1 file changed, 1 insertion(+) create mode 100644 Test0011.txt diff --git a/Test0011.txt b/Test0011.txt new file mode 100644 index 0000000..56fbf54 --- /dev/null +++ b/Test0011.txt @@ -0,0 +1 @@ +Add test file -- 2.25.1 From tianocoregitactionbot at gmail.com Tue Jun 22 23:00:40 2021 From: tianocoregitactionbot at gmail.com (edk2codereviewtest via TianoCore Webhook) Date: Tue, 22 Jun 2021 16:00:40 -0700 Subject: [edk2-codereview][PATCH v1 0/1] edk2-codereview: Add file Test0011.txt Message-ID: #### # PR(open): https://github.com/tianocore/edk2-codereview/pull/17 # Base SHA: 16826b354211e0de7b6f76b8594ebf515ad36b73 # Submitter: [edk2codereviewtest] # Maintainer: Leif Lindholm [leiflindholm] # Maintainer: Laszlo Ersek [lersek] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Andrew Fish [ajfish] #### Signed-off-by: EDK II Code Review Test EDK II Code Review Test (1): edk2-codereview: Add file Test0011.txt Test0011.txt | 1 + 1 file changed, 1 insertion(+) create mode 100644 Test0011.txt -- From tianocoregitactionbot at gmail.com Tue Jun 22 22:39:36 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Tue, 22 Jun 2021 15:39:36 -0700 Subject: [edk2-codereview][PATCH v1 0/1] Revert "edk2-codereview: Add another file" In-Reply-To: Message-ID: > #### > # PR(open): https://github.com/tianocore/edk2-codereview/pull/15 > # Base SHA: 7fa5662e1fafba6aea4dea4b2b5fadae25d2d798 > # Submitter: [edk2codereviewtest] > # Maintainer: Leif Lindholm [leiflindholm] > # Maintainer: Laszlo Ersek [lersek] > # Maintainer: Michael D Kinney [mdkinney] > # Maintainer: Andrew Fish [ajfish] > #### > > This reverts commit 995c5bde03da0e0557fc7a39bd9ebe533c4559b7. -------------------- On 2021-06-22 22:39:32 @mdkinney wrote: Need to add Signed-off-by to commit message -------------------- From tianocoregitactionbot at gmail.com Tue Jun 22 23:12:09 2021 From: tianocoregitactionbot at gmail.com (edk2codereviewtest via TianoCore Webhook) Date: Tue, 22 Jun 2021 16:12:09 -0700 Subject: [edk2-codereview][PATCH v2 0/1] edk2-codereview: Add file Test0011.txt Message-ID: #### # PR(open): https://github.com/tianocore/edk2-codereview/pull/17 # Base SHA: 16826b354211e0de7b6f76b8594ebf515ad36b73 # Submitter: [edk2codereviewtest] # Maintainer: Leif Lindholm [leiflindholm] # Maintainer: Laszlo Ersek [lersek] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Andrew Fish [ajfish] #### Signed-off-by: EDK II Code Review Test EDK II Code Review Test (1): edk2-codereview: Add file Test0011.txt Test0011.txt | 1 + 1 file changed, 1 insertion(+) create mode 100644 Test0011.txt -- From tianocoregitactionbot at gmail.com Tue Jun 22 23:00:06 2021 From: tianocoregitactionbot at gmail.com (edk2codereviewtest via TianoCore Webhook) Date: Tue, 22 Jun 2021 16:00:06 -0700 Subject: [edk2-codereview][PATCH v2 1/1] edk2-codereview: Add file Test0011.txt In-Reply-To: Message-ID: From: EDK II Code Review Test Signed-off-by: EDK II Code Review Test --- #### # PR(open): https://github.com/tianocore/edk2-codereview/pull/17 # Base SHA: 16826b354211e0de7b6f76b8594ebf515ad36b73 # Submitter: [edk2codereviewtest] # Commit: https://github.com/tianocore/edk2-codereview/commit/5e80663bafd3cb8c5b8f9b1faf9aaa92ed0a0700 # Maintainer: Leif Lindholm [leiflindholm] # Maintainer: Laszlo Ersek [lersek] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Andrew Fish [ajfish] #### Test0011.txt | 1 + 1 file changed, 1 insertion(+) create mode 100644 Test0011.txt diff --git a/Test0011.txt b/Test0011.txt new file mode 100644 index 0000000..ffaa477 --- /dev/null +++ b/Test0011.txt @@ -0,0 +1 @@ +Add test file -- 2.25.1 From tianocoregitactionbot at gmail.com Tue Jun 22 22:59:00 2021 From: tianocoregitactionbot at gmail.com (edk2codereviewtest via TianoCore Webhook) Date: Tue, 22 Jun 2021 15:59:00 -0700 Subject: [edk2-codereview][PATCH v2 1/1] edk2-codereview: Add Test0010.txt In-Reply-To: Message-ID: From: EDK II Code Review Test Signed-off-by: EDK II Code Review Test --- #### # PR(open): https://github.com/tianocore/edk2-codereview/pull/16 # Base SHA: 16826b354211e0de7b6f76b8594ebf515ad36b73 # Submitter: [edk2codereviewtest] # Commit: https://github.com/tianocore/edk2-codereview/commit/a0cf01477a08475fa81661df04ce6c921a2ec149 # Maintainer: Leif Lindholm [leiflindholm] # Maintainer: Laszlo Ersek [lersek] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Andrew Fish [ajfish] #### Test0010.txt | 1 + 1 file changed, 1 insertion(+) create mode 100644 Test0010.txt diff --git a/Test0010.txt b/Test0010.txt new file mode 100644 index 0000000..ffaa477 --- /dev/null +++ b/Test0010.txt @@ -0,0 +1 @@ +Add test file -- 2.25.1 From tianocoregitactionbot at gmail.com Tue Jun 22 23:13:44 2021 From: tianocoregitactionbot at gmail.com (edk2codereviewtest via TianoCore Webhook) Date: Tue, 22 Jun 2021 16:13:44 -0700 Subject: [edk2-codereview][PATCH v2 0/1] edk2-codereview: Add Test0010.txt Message-ID: #### # PR(open): https://github.com/tianocore/edk2-codereview/pull/16 # Base SHA: 16826b354211e0de7b6f76b8594ebf515ad36b73 # Submitter: [edk2codereviewtest] # Maintainer: Leif Lindholm [leiflindholm] # Maintainer: Laszlo Ersek [lersek] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Andrew Fish [ajfish] #### Signed-off-by: EDK II Code Review Test EDK II Code Review Test (1): edk2-codereview: Add Test0010.txt Test0010.txt | 1 + 1 file changed, 1 insertion(+) create mode 100644 Test0010.txt -- From tianocoregitactionbot at gmail.com Tue Jun 22 23:18:47 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Tue, 22 Jun 2021 16:18:47 -0700 Subject: [edk2-codereview][PATCH v2 0/1] edk2-codereview: Add Test0010.txt In-Reply-To: Message-ID: > #### > # PR(open): https://github.com/tianocore/edk2-codereview/pull/16 > # Base SHA: 16826b354211e0de7b6f76b8594ebf515ad36b73 > # Submitter: [edk2codereviewtest] > # Maintainer: Leif Lindholm [leiflindholm] > # Maintainer: Laszlo Ersek [lersek] > # Maintainer: Michael D Kinney [mdkinney] > # Maintainer: Andrew Fish [ajfish] > #### > > Signed-off-by: EDK II Code Review Test -------------------- On 2021-06-22 23:18:43 @mdkinney started a review with state APPROVED: -------------------- From tianocoregitactionbot at gmail.com Tue Jun 22 23:19:13 2021 From: tianocoregitactionbot at gmail.com (mdkinney via TianoCore Webhook) Date: Tue, 22 Jun 2021 16:19:13 -0700 Subject: [edk2-codereview][PATCH v2 0/1] edk2-codereview: Add file Test0011.txt In-Reply-To: Message-ID: > #### > # PR(open): https://github.com/tianocore/edk2-codereview/pull/17 > # Base SHA: 16826b354211e0de7b6f76b8594ebf515ad36b73 > # Submitter: [edk2codereviewtest] > # Maintainer: Leif Lindholm [leiflindholm] > # Maintainer: Laszlo Ersek [lersek] > # Maintainer: Michael D Kinney [mdkinney] > # Maintainer: Andrew Fish [ajfish] > #### > > Signed-off-by: EDK II Code Review Test -------------------- On 2021-06-22 23:19:09 @mdkinney started a review with state APPROVED: -------------------- From tianocoregitactionbot at gmail.com Tue Jun 22 22:59:00 2021 From: tianocoregitactionbot at gmail.com (edk2codereviewtest via TianoCore Webhook) Date: Tue, 22 Jun 2021 15:59:00 -0700 Subject: [edk2-codereview][PATCH v2 2/2] edk2-codereview: Add Test0010.txt In-Reply-To: Message-ID: From: EDK II Code Review Test Signed-off-by: EDK II Code Review Test --- #### # PR(open): https://github.com/tianocore/edk2-codereview/pull/17 # Base SHA: 13edd2706fcad15c992dbc14a4042c30b7828f78 # Submitter: [edk2codereviewtest] # Commit: https://github.com/tianocore/edk2-codereview/commit/4f12d153fa1ee473f99cfe8d7b67d01587b71770 # Maintainer: Leif Lindholm [leiflindholm] # Maintainer: Laszlo Ersek [lersek] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Andrew Fish [ajfish] #### Test0010.txt | 1 + 1 file changed, 1 insertion(+) create mode 100644 Test0010.txt diff --git a/Test0010.txt b/Test0010.txt new file mode 100644 index 0000000..ffaa477 --- /dev/null +++ b/Test0010.txt @@ -0,0 +1 @@ +Add test file -- 2.25.1 From tianocoregitactionbot at gmail.com Tue Jun 22 23:21:35 2021 From: tianocoregitactionbot at gmail.com (edk2codereviewtest via TianoCore Webhook) Date: Tue, 22 Jun 2021 16:21:35 -0700 Subject: [edk2-codereview][PATCH v2 0/1] edk2-codereview: Add Test0010.txt In-Reply-To: Message-ID: #### # PR(closed): https://github.com/tianocore/edk2-codereview/pull/16 # Base SHA: 16826b354211e0de7b6f76b8594ebf515ad36b73 # Submitter: [edk2codereviewtest] # Maintainer: Leif Lindholm [leiflindholm] # Maintainer: Laszlo Ersek [lersek] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Andrew Fish [ajfish] #### Signed-off-by: EDK II Code Review Test EDK II Code Review Test (1): edk2-codereview: Add Test0010.txt Test0010.txt | 1 + 1 file changed, 1 insertion(+) create mode 100644 Test0010.txt -- From tianocoregitactionbot at gmail.com Tue Jun 22 23:26:53 2021 From: tianocoregitactionbot at gmail.com (edk2codereviewtest via TianoCore Webhook) Date: Tue, 22 Jun 2021 16:26:53 -0700 Subject: [edk2-codereview][PATCH v2 0/1] edk2-codereview: Add file Test0011.txt In-Reply-To: Message-ID: #### # PR(closed): https://github.com/tianocore/edk2-codereview/pull/17 # Base SHA: 13edd2706fcad15c992dbc14a4042c30b7828f78 # Submitter: [edk2codereviewtest] # Maintainer: Leif Lindholm [leiflindholm] # Maintainer: Laszlo Ersek [lersek] # Maintainer: Michael D Kinney [mdkinney] # Maintainer: Andrew Fish [ajfish] #### Signed-off-by: EDK II Code Review Test EDK II Code Review Test (1): edk2-codereview: Add file Test0011.txt Test0011.txt | 1 + 1 file changed, 1 insertion(+) create mode 100644 Test0011.txt --