[PATCH 07] rework prepare_ptrace_attach/finish_ptrace_attach

Roland McGrath roland at redhat.com
Tue Aug 18 00:07:09 UTC 2009


> +	/*
> +	 * It can fail only if the tracee is dead, the caller
> +	 * must notice this before setting PT_PTRACED.
> +	 */
> +	utrace_set_events(tracee, engine, events);

I'd say put at least a WARN_ON(ret) there if you are really assuming success.


Thanks,
Roland




More information about the utrace-devel mailing list