[PATCH 57] UTRACE_SIGNAL_HANDLER should never see ->siginfo != NULL

Oleg Nesterov oleg at redhat.com
Thu Sep 24 00:40:07 UTC 2009


ptrace_report_signal(UTRACE_SIGNAL_HANDLER) should be never called
with a valid context->siginfo, move the corresponding WARN_ON() up.

---

 kernel/ptrace.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- PU/kernel/ptrace.c~57_SIGNAL_HANDLER_WARN_ALWAYS	2009-09-24 02:03:09.000000000 +0200
+++ PU/kernel/ptrace.c	2009-09-24 02:14:17.000000000 +0200
@@ -374,10 +374,10 @@ static u32 ptrace_report_signal(u32 acti
 
 	switch (utrace_signal_action(action)) {
 	case UTRACE_SIGNAL_HANDLER:
-		if (resume != UTRACE_RESUME) {
-			if (WARN_ON(context->siginfo))
-				context->siginfo = NULL;
+		if (WARN_ON(context->siginfo))
+			context->siginfo = NULL;
 
+		if (resume != UTRACE_RESUME) {
 			ev = ev_push(context);
 			ev->ev_code = SIGTRAP;
 




More information about the utrace-devel mailing list