[PATCH 53-56] kill ->ev_array + fix stepping

Roland McGrath roland at redhat.com
Wed Oct 7 06:45:47 UTC 2009


> On top of 4492770dc8d2312da9518e8b85fb0e49dc3da510 in your
> utrace-ptrace branch.

I had done an upstream merge since then and also merged some more of
yours.  So to get utrace-ptrace back to a state where 53-70 apply cleanly,
I reverted these first:

6752625 introduce context_siginfo() helper
d43a453 UTRACE_SIGNAL_HANDLER should never see ->siginfo != NULL
e4e48df ptrace_resume_signal() should use context->siginfo under ->siglock

We could be nearing the point where it would be easier if you were using a
GIT repository directly that I can pull from.  But it was in fact no real
problem to recover how to merge this time, so you still don't need to worry
about that if you don't want to.

Right now my trees fork from v2.6.32-rc3 and include 53-70:

	fbd4368 kill context->ev_array[]
	ba73824 ptrace_resume: don't ignore "data" argument
	a55d174 implement the stacked SYSCALL_EXIT event
	08f4a21 fix the stepping over syscall
	d0ed18d do_ptrace_notify_stop: backport the "sync wakeup" logic
	842684f do_ptrace_notify_stop: fix the race with SIGKILL
	e90cb71 don't use task_struct->ptrace_message
	0768d89 UTRACE_SIGNAL_HANDLER should never see ->siginfo != NULL
	c625793 move "resume signal" logic into the tracee's context
	e7ac055 introduce ptrace_rw_siginfo() helper
	53187be convert ptrace_getsiginfo() to use ptrace_rw_siginfo()
	4e09fe3 convert ptrace_setsiginfo() to use ptrace_rw_siginfo()
	47b5e2c don't clear context->ev_code for debugging
	313bad1 introduce syscall_code(context) helper
	3f48297 introduce get_stop_code(context) helper
	df7c8f2 encode internal stop events in ->ev_code too
	4c99287 kill context->ev_name
	f83b2ca move "event << 8" into syscall_code()

For whatever review comments I may have about these (to follow shortly),
I'll just expect you to incorporate those issues into later cleanups.


Thanks,
Roland




More information about the utrace-devel mailing list