[PATCH 65-69] kill context->ev_name

Oleg Nesterov oleg at redhat.com
Wed Oct 7 12:05:27 UTC 2009


On 10/07, Roland McGrath wrote:
>
> > Naming: as usual, I agree in advance with any suggestions.
>
> The ev_ prefix no longer refers to anything inherently obvious in the code.
> If you want a common prefix for the struct it should be on all its fields
> and it should be something evocative of "struct ptrace_context".  (I'm not
> big on common prefixes for struct fields but I understand why you like them.)
>
> I'd use "eventmsg" for the thing whose purpose is for PTRACE_GETEVENTMSG to
> return it.
>
> I'd use either "exit_code" or "stop_code" for the thing that either is
> assigned to task_struct.exit_code (now) or just acts like it for purposes
> of ptrace_do_wait (hopefully future).
>
> s/ev_pending/ptrace_event_pending/
> s/get_stop_code/get_stop_event/ (or maybe ptrace_ctx_event)

OK.

Oleg.




More information about the utrace-devel mailing list