[PATCH 0/1] Was: utrace-cleanup branch

Roland McGrath roland at redhat.com
Tue Nov 3 22:11:12 UTC 2009


> 8. Completely off-topic, but utrace_control() has a very strange comment
>    under "case UTRACE_INTERRUPT",
> 
> 	 * When it's stopped, we know it's always going
> 	 * through utrace_get_signal() and will recalculate.
> 
>    can't recall if it were ever true, but surely it is not now?

I think what's true now is what's always been true.  The comment is a bit
confusing, though.  The two kinds of stopped are inside do_signal_stop()
and inside utrace_stop().  In the former, it is inside the signal-checking
loop and will check again.  In the latter, utrace_stop() ends with a call
to recalc_sigpending().


Thanks,
Roland




More information about the utrace-devel mailing list