[PATCH 0/2] Was: introduce suppress_sigtrap() to prevent unwanted send_sigtrap()

Roland McGrath roland at redhat.com
Wed Nov 11 04:18:24 UTC 2009


> But syscall_trace_leave() uses TRAP_BRKPT on x86. Should I change 4/5 ?

Oh, I was sloppy in checking the values this time.  Then probably the
default TRAP_SINGLE_STEP should be 0 instead just to make clear that every
arch needs to define it.  But your other way is fine instead too.

> The new version of default helper is really trivial, an  it is only inlined
> if the arch code doesn't care about the right implementation. Perhaps it can
> stay in ptrace.h?

I don't care.  Do whatever you think is best and that upstream reviewers like.


Thanks,
Roland




More information about the utrace-devel mailing list