[virt-tools-list] [virt-viewer] spec: Update mingw BuildRequires

Daniel P. Berrange berrange at redhat.com
Tue Dec 16 13:41:06 UTC 2014


On Tue, Dec 16, 2014 at 02:27:20PM +0100, Fabiano Fidêncio wrote:
> On Tue, 2014-12-16 at 13:24 +0000, Daniel P. Berrange wrote:
> > On Tue, Dec 16, 2014 at 02:02:16PM +0100, Christophe Fergeau wrote:
> > > Several new dependencies were added with the recent msi installer
> > > update.
> > > ---
> > >  mingw-virt-viewer.spec.in | 8 ++++++++
> > >  1 file changed, 8 insertions(+)
> > > 
> > > diff --git a/mingw-virt-viewer.spec.in b/mingw-virt-viewer.spec.in
> > > index ea8c20b..599ca8a 100644
> > > --- a/mingw-virt-viewer.spec.in
> > > +++ b/mingw-virt-viewer.spec.in
> > > @@ -24,12 +24,16 @@ Source0:        ftp://virt-manager.org/downloads/virt-viewer/virt-viewer-%{versi
> > >  
> > >  BuildRequires:  mingw32-filesystem >= 23
> > >  BuildRequires:  mingw64-filesystem >= 23
> > > +BuildRequires:  mingw32-glib-networking
> > > +BuildRequires:  mingw64-glib-networking
> > 
> > I'm not seeing any reference to this in our source tree - where is
> > it used ?
> 
> It is a libsoup dependency (but not set as dependency in the
> mingw*-libsoup):
> https://bugzilla.redhat.com/show_bug.cgi?id=1169185

Ok, so we should reference that BZ in the spec, so we know why it was
added & can remove it later.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the virt-tools-list mailing list