[virt-tools-list] [remote-viewer PATCH 0/7 v2] remote-viewer: Rewrite of connect dialog

Lukas Venhoda lvenhoda at redhat.com
Thu Jun 11 14:28:35 UTC 2015


Connect dialog was hardcoded, and sometimes didn't have a parent window.

Changed dialog to a window.
Moved UI definition from code to XML.
Moved the "dialog" code to its own module.
Fixed some issues with the original dialog.

---
Changes since v1
 - Split the 3 patches into 7
 - Hopefully this new split makes more sense
 - Adressed some more issues
---

Lukas Venhoda (7):
  remote-viewer: Connect dialog moved to its own file
  remote-viewer-connect: Changed response to GtkResponseType
  remote-viewer-connect: Free uri before writing to it
  remote-viewer-connect: Changed dialog into a window
  remote-viewer-connect: Changed hardcoded UI into XML
  remote-viewer-connect: Fixed reselecting in recent chooser
  remote-viewer-connect: Address entry is now required

 po/POTFILES.in                |   1 +
 src/Makefile.am               |   2 +
 src/remote-viewer-connect.c   | 263 ++++++++++++++++++++++++++++++++++++++++++
 src/remote-viewer-connect.h   |  36 ++++++
 src/remote-viewer-connect.xml | 152 ++++++++++++++++++++++++
 src/remote-viewer.c           | 162 +-------------------------
 6 files changed, 456 insertions(+), 160 deletions(-)
 create mode 100644 src/remote-viewer-connect.c
 create mode 100644 src/remote-viewer-connect.h
 create mode 100644 src/remote-viewer-connect.xml

--
2.4.2




More information about the virt-tools-list mailing list