[virt-tools-list] [PATCH virt-viewer v2 3/3] ovirt: Allow to cancel authentication without showing error dialog

Pavel Grunt pgrunt at redhat.com
Wed Mar 18 15:09:47 UTC 2015


> 
> Oh, so it does synchronous network communication. I didn't expect
> that.
> When I initially looked at the code for this function, I didn't see
> it.
> But after looking more closely, I see that it does. hmmm. Is there
> any
> way that we can change libgovirt to return a special CANCELLED error
> code from this call as well? authenticate_cb() does return a boolean
> that could presumably be used to determine whether auth was tried or
> not.

ok, I have to look how the return value is handled in librest...

> Otherwise I guess we'll have to just stay with the get|
> set_user_cancelled() approach...
> 
or use the GError approach and do it similar to v1 of this patch

Pavel




More information about the virt-tools-list mailing list