[virt-tools-list] [PATCH] details: show Channel label by device type

Cole Robinson crobinso at redhat.com
Tue Nov 10 21:27:43 UTC 2015


On 11/10/2015 09:01 AM, Chen Hanxiao wrote:
> From: Chen Hanxiao <chenhanxiao at gmail.com>
> 
> Currently we show channel label by its name.
> If we use name com.redhat.spice.0 but set it
> as unix socket, the label in details keep unchanged.
> 
> This patch will set label according to device type.
> 

But this loses the nice spice/qemu channel labeling for the common case with
the default virt-manager channels. IMO this change doesn't improve things

- Cole

> Signed-off-by: Chen Hanxiao <chenhanxiao at gmail.com>
> ---
>  virtManager/details.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/virtManager/details.py b/virtManager/details.py
> index 742448d..b1f2662 100644
> --- a/virtManager/details.py
> +++ b/virtManager/details.py
> @@ -213,7 +213,7 @@ def _label_for_device(dev):
>  
>      if devtype == "channel":
>          label = _("Channel")
> -        name = dev.pretty_channel_name(dev.target_name)
> +        name = dev.pretty_type(dev.type)
>          if name:
>              label += " %s" % name
>          return label
> 




More information about the virt-tools-list mailing list