[virt-tools-list] [virt-manager][PATCH 1/3] tests: Update virt-install-many-devices.xml

Cole Robinson crobinso at redhat.com
Fri Jan 15 16:47:48 UTC 2016


On 01/15/2016 02:27 AM, Michal Privoznik wrote:
> Libvirt started to put type='raw' to <driver/> element to disks
> when no type has been provided. We should reflect that change in
> our tests too.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  tests/cli-test-xml/compare/virt-install-many-devices.xml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/cli-test-xml/compare/virt-install-many-devices.xml b/tests/cli-test-xml/compare/virt-install-many-devices.xml
> index 79eb189..248a59f 100644
> --- a/tests/cli-test-xml/compare/virt-install-many-devices.xml
> +++ b/tests/cli-test-xml/compare/virt-install-many-devices.xml
> @@ -76,12 +76,12 @@
>        <target dev="vdf" bus="virtio"/>
>      </disk>
>      <disk type="volume" device="disk">
> -      <driver name="qemu"/>
> +      <driver name="qemu" type="raw"/>
>        <source volume="some-rbd-vol" pool="rbd-ceph"/>
>        <target dev="vdg" bus="virtio"/>
>      </disk>
>      <disk type="network" device="disk">
> -      <driver name="qemu"/>
> +      <driver name="qemu" type="raw"/>
>        <source protocol="rbd" name="rbd/foobar">
>          <host name="ceph-mon-1.example.com" port="6789"/>
>        </source>
> 

I needed to expand this to skip the test on older libvirt, so I can still run
the test suite on stock f23 for example. It's fixed in git though

Thanks,
Cole




More information about the virt-tools-list mailing list