[virt-tools-list] [PATCH virt-viewer v2 0/5] Improve warning messages for hotkeys parsing

Pavel Grunt pgrunt at redhat.com
Mon May 30 15:08:35 UTC 2016


Hi,

These patches changes/improves/add warning messages when a problem occurs during
parsing of hotkeys.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1339572

Changes since v1:
 - Added tests
 - Added a warning when hotkey's value is invalid

Thanks,

Pavel Grunt (5):
  Include virt-viewer-util where needed
  app: Use debug to inform about smartcard shortcuts state
  tests: Add hotkeys test
  app: Check validity of hotkey value
  app: Inform about problematic hotkey

 src/remote-viewer-main.c |   1 +
 src/remote-viewer.c      |   1 +
 src/virt-viewer-app.c    |  11 ++--
 src/virt-viewer-app.h    |   1 -
 src/virt-viewer-auth.c   |   1 +
 src/virt-viewer-auth.h   |   1 -
 src/virt-viewer-main.c   |   1 +
 src/virt-viewer.c        |   1 +
 tests/Makefile.am        |  12 ++++-
 tests/test-hotkeys.c     | 127 +++++++++++++++++++++++++++++++++++++++++++++++
 10 files changed, 151 insertions(+), 6 deletions(-)
 create mode 100644 tests/test-hotkeys.c

-- 
2.8.3




More information about the virt-tools-list mailing list