Michael, This looks much better. Thanks Haydn <div class="gmail_quote">On Wed, Aug 5, 2009 at 6:10 AM, Michal Novotny <<a href="mailto:minovotn@redhat.com">minovotn@redhat.com</a>> wrote: <blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Hi Haydn, you were right. It was not working right in some circumstances - the values of allocation & size were not reset when type was not 'file' and this is the corrected version of this patch. Thanks once again Haydn... <div><div></div><div class="h5"> Thanks, Michal ----- Original Message ----- From: "Haydn Solomon" <<a href="mailto:haydn.solomon@gmail.com">haydn.solomon@gmail.com</a>> To: "Michal Novotny" <<a href="mailto:minovotn@redhat.com">minovotn@redhat.com</a>> Cc: <a href="mailto:virt-tools-list@redhat.com">virt-tools-list@redhat.com</a> Sent: Tuesday, August 4, 2009 6:29:41 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: [virt-tools-list] [PATCH] Show disk allocation & size on Details tab in VMM Michael, Thanks for your patch. I have one comment based on my observation. I noticed that if the cdrom is not connected, it shows the capacity of the primary disk. The cdrom source type shows as block when disconnected but file when connected. On Tue, Aug 4, 2009 at 12:02 PM, Michal Novotny < <a href="mailto:minovotn@redhat.com">minovotn@redhat.com</a> > wrote: Hi, sorry, I made a mistake here preventing it to show size and even work correctly in some circumstances, this is updated version of this patch. Thanks, Michal ----- Original Message ----- From: "Michal Novotny" < <a href="mailto:minovotn@redhat.com">minovotn@redhat.com</a> > To: <a href="mailto:virt-tools-list@redhat.com">virt-tools-list@redhat.com</a> Sent: Tuesday, August 4, 2009 5:39:23 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: [virt-tools-list] [PATCH] Show disk allocation & size on Details tab in VMM Hi, this is a patch for virt-manager (VMM for short) that allows user see the current allocation and disk size. It's working fine for both managed and unmanaged storages, however getting allocation information is possible only for managed ones so that there is just "N/A" string shown in disk allocation field if looking on unmanaged storage details. It's also showing disk size of CD-ROM devices assigned for this VM... Please review, thanks, Michal _______________________________________________ virt-tools-list mailing list <a href="mailto:virt-tools-list@redhat.com">virt-tools-list@redhat.com</a> <a href="https://www.redhat.com/mailman/listinfo/virt-tools-list" target="_blank">https://www.redhat.com/mailman/listinfo/virt-tools-list</a> _______________________________________________ virt-tools-list mailing list <a href="mailto:virt-tools-list@redhat.com">virt-tools-list@redhat.com</a> <a href="https://www.redhat.com/mailman/listinfo/virt-tools-list" target="_blank">https://www.redhat.com/mailman/listinfo/virt-tools-list</a> </div></div></blockquote></div>