<div dir="ltr">ack<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jun 11, 2013 at 4:15 PM, Christophe Fergeau <span dir="ltr"><<a href="mailto:cfergeau@redhat.com" target="_blank">cfergeau@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">For some VMs, setting host subject on SpiceSession is needed to<br>
be able to connect to it using SPICE/SSL. Until recently, this<br>
was not exposed in oVirt REST API/libgovirt. Since<br>
oVirt 3.2/libgovirt 0.1.0, the host subject is available, this<br>
patch makes use of it.<br>
This should fix connection to oVirt VMs that were migrated to a<br>
different host than the one they were started on.<br>
---<br>
<a href="http://configure.ac" target="_blank">configure.ac</a> | 2 +-<br>
src/remote-viewer.c | 4 ++++<br>
2 files changed, 5 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/<a href="http://configure.ac" target="_blank">configure.ac</a> b/<a href="http://configure.ac" target="_blank">configure.ac</a><br>
index c7fb5c8..4cf6a60 100644<br>
--- a/<a href="http://configure.ac" target="_blank">configure.ac</a><br>
+++ b/<a href="http://configure.ac" target="_blank">configure.ac</a><br>
@@ -178,7 +178,7 @@ AC_ARG_WITH([ovirt],<br>
AS_HELP_STRING([--without-ovirt], [Ignore presence of librest and disable oVirt support]))<br>
<br>
AS_IF([test "x$with_ovirt" != "xno"],<br>
- [PKG_CHECK_MODULES([OVIRT], [govirt-1.0],<br>
+ [PKG_CHECK_MODULES([OVIRT], [govirt-1.0 >= 0.1.0],<br>
[have_ovirt=yes], [have_ovirt=no])],<br>
[have_ovirt=no])<br>
<br>
diff --git a/src/remote-viewer.c b/src/remote-viewer.c<br>
index 2bb4192..d0e70eb 100644<br>
--- a/src/remote-viewer.c<br>
+++ b/src/remote-viewer.c<br>
@@ -730,6 +730,7 @@ create_ovirt_session(VirtViewerApp *app, const char *uri)<br>
gchar *gtlsport = NULL;<br>
gchar *ghost = NULL;<br>
gchar *ticket = NULL;<br>
+ gchar *host_subject = NULL;<br>
<br>
g_return_val_if_fail(VIRT_VIEWER_IS_APP(app), FALSE);<br>
<br>
@@ -777,6 +778,7 @@ create_ovirt_session(VirtViewerApp *app, const char *uri)<br>
"port", &port,<br>
"secure-port", &secure_port,<br>
"ticket", &ticket,<br>
+ "host-subject", &host_subject,<br>
NULL);<br>
gport = g_strdup_printf("%d", port);<br>
gtlsport = g_strdup_printf("%d", secure_port);<br>
@@ -806,6 +808,7 @@ create_ovirt_session(VirtViewerApp *app, const char *uri)<br>
g_object_set(G_OBJECT(session),<br>
"ca", ca_cert,<br>
"password", ticket,<br>
+ "cert-subject", host_subject,<br>
NULL);<br>
g_byte_array_unref(ca_cert);<br>
}<br>
@@ -820,6 +823,7 @@ error:<br>
g_free(gport);<br>
g_free(gtlsport);<br>
g_free(ghost);<br>
+ g_free(host_subject);<br>
<br>
if (error != NULL)<br>
g_error_free(error);<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.8.2.1<br>
<br>
_______________________________________________<br>
virt-tools-list mailing list<br>
<a href="mailto:virt-tools-list@redhat.com">virt-tools-list@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/virt-tools-list" target="_blank">https://www.redhat.com/mailman/listinfo/virt-tools-list</a><br>
</font></span></blockquote></div><br><br clear="all"><br>-- <br>Marc-André Lureau
</div>