<div dir="ltr">Regardless there is another iteration of --debug handling, I am pushing this fix as trivial. </div><div class="gmail_extra"> <div class="gmail_quote">On Thu, Jun 12, 2014 at 8:21 AM, Christophe Fergeau <<a href="mailto:cfergeau@redhat.com" target="_blank">cfergeau@redhat.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="">On Wed, Jun 11, 2014 at 11:54:31AM -0400, Marc-André Lureau wrote: > > > ----- Original Message ----- > > On Wed, Jun 11, 2014 at 05:21:59PM +0200, Marc-André Lureau wrote: > > > glib_check_version() returns NULL if version is higher or equal. > > > --- > > > src/virt-viewer-util.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/src/virt-viewer-util.c b/src/virt-viewer-util.c > > > index c81c09a..6fdaa07 100644 > > > --- a/src/virt-viewer-util.c > > > +++ b/src/virt-viewer-util.c > > > @@ -283,7 +283,7 @@ static void log_handler(const gchar *log_domain, > > > const gchar *message, > > > gpointer unused_data) > > > { > > > - if (!glib_check_version(2, 32, 0)) > > > + if (glib_check_version(2, 32, 0) != NULL) > > > if (log_level >= G_LOG_LEVEL_DEBUG && !doDebug) > > > return; > > > > > > Or maybe this? > > Well, it's not like we are using a different API, so I prefer the dynamic version. </div>Sorry, I did not understand what you mean in the first part of your sentence :( Christophe _______________________________________________ virt-tools-list mailing list <a href="mailto:virt-tools-list@redhat.com">virt-tools-list@redhat.com</a> <a href="https://www.redhat.com/mailman/listinfo/virt-tools-list" target="_blank">https://www.redhat.com/mailman/listinfo/virt-tools-list</a> </blockquote></div> -- Marc-André Lureau </div>